Removed custom_encoder option #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix logging and checkpointing bug * Add option to validate every n steps
Fixes minor issues in Noble-Lab#165.
* Always use full file paths Fixes Noble-Lab#167. * Update changelog * Formatting fix
* Only split off extension if it's mzTab * Also check for .log extension * Update output format in help message
* Add FAQ about using Casanovo for new PTMs * Update based on Bill's feedback
* Add non-enzymatic weights description to docs * Update weights information --------- Co-authored-by: Wout Bittremieux <[email protected]>
* Don't assign output files during eval mode * Update changelog
* Fix specifying custom residues * Update changelog
bittremieux
requested changes
Oct 11, 2023
There was a problem hiding this comment.
I changed the base from main to dev, because that's where our current development happen. For your future PRs, please start from dev.
This now messed up the change history unfortunately, because your code didn't include the dev changes yet. Can you rebase to dev and force push that version so that the history is clean?
Additionally, there are still some locations where custom_encoder is used in model.py.
Also include a line in the CHANGELOG with the changes that have been made.
|
Superseded by #254. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved issue #238