-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Casanovo-DB Functionality #325
base: dev
Are you sure you want to change the base?
Conversation
Can you make sure the unit tests succeed? On a quick glance, without looking at the content of the code, please also adhere to the maximum line length for strings (both within code and docstrings). Black doesn't do this automatically. |
I will definitely take a look at the line lengths and fix them if they are over the maximum. As for the unit tests, the only one failing is the
|
No, I don't think that this is the same problem. #301 tries to do tests on the Mac M1 chips, which indeed doesn't work. The current tests on |
@VarunAnanth2003 To avoid running on MPS-supported macOS versions, in the GitHub test action, change |
The macOS version has been fixed in #327, so just merge |
Move macOS test fixes from dev
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #325 +/- ##
==========================================
+ Coverage 94.37% 94.68% +0.31%
==========================================
Files 13 14 +1
Lines 1102 1298 +196
==========================================
+ Hits 1040 1229 +189
- Misses 62 69 +7 ☔ View full report in Codecov by Sentry. |
Full implementation of Casanovo-DB
This branch is currently fully up to date with |
By default, Casanovo-DB should only report the top scoring PSM for each spectrum, and there should be a paremater top_n that allows the user to ask for more (like for tide). Currently, reporting all PSMs requires a huge amount of memory, and the resulting output file for even a modest run is 100+ Gb, which is impractical for most users who just care about the top id for each spectrum. |
Yes, definitely. Casanovo-DB should adhere to the value set for |
Added functionality of Casanovo-DB that builds on top of Tide (Phase 1).
This is accomplished through two new commands,
annotate
anddb-search
.Most of the functionality is created through subclassing existing classes as only minor modifications are needed to get the data flow to work.