Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorboard io #374

Merged
merged 29 commits into from
Sep 16, 2024
Merged

Tensorboard io #374

merged 29 commits into from
Sep 16, 2024

Conversation

Lilferrit
Copy link
Contributor

TensorBoard summary writer now writes to a subdirectory of --output_dir, <output_dir>/tensorboard. The config option tb_summarywriter has been redefined to be a boolean, and if set to true the TensorBoard summary will be written to the output directory.

I am marking this PR as a draft until console-file-io get's merged into dev, as this branch is based on console-file-io and is dependent on changes introduced in that branch.

@Lilferrit Lilferrit marked this pull request as draft September 6, 2024 18:45
@Lilferrit
Copy link
Contributor Author

Alternatively we could introduce a --tensorboard or similar command line option, and eliminate the tb_summarywriter config option entirely.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.40%. Comparing base (4cff0c8) to head (f9b0895).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
casanovo/denovo/model_runner.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #374      +/-   ##
==========================================
- Coverage   94.47%   94.40%   -0.07%     
==========================================
  Files          12       12              
  Lines        1067     1073       +6     
==========================================
+ Hits         1008     1013       +5     
- Misses         59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bittremieux bittremieux changed the base branch from dev to console-file-io September 8, 2024 11:50
Copy link
Collaborator

@bittremieux bittremieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after #372 has been completed.

@bittremieux bittremieux marked this pull request as ready for review September 8, 2024 11:53
@bittremieux
Copy link
Collaborator

Alternatively we could introduce a --tensorboard or similar command line option, and eliminate the tb_summarywriter config option entirely.

No, the current solution is better. This is not a very important setting that we want to expose on the command line.

@bittremieux bittremieux linked an issue Sep 8, 2024 that may be closed by this pull request
Base automatically changed from console-file-io to dev September 16, 2024 19:51
@Lilferrit Lilferrit merged commit aefa73c into dev Sep 16, 2024
4 of 6 checks passed
@Lilferrit Lilferrit deleted the tensorboard-io branch September 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write TensorBoard summary to output directory.
2 participants