Astro: Fix broken links + various changes #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line endings in the `FileSystemVaultTests` file were changed from `\n` to `\r\n`. This commit fixes the assertions that compare string values to use the correct line endings.
- Updated assertion messages to use Environment.NewLine instead of "\r\n"
This commit adds support for canonical paths in the routing table of the VaultManifestClient class. Now, when processing files with a .md extension, the code checks if the file path matches a specific regex pattern and handles it accordingly. If the file path ends with .md, it extracts the canonical path by removing the .md extension. If the file path also matches another regex pattern, it further modifies the canonical path before adding it to the routing table. This change improves how files are processed and stored in the routing table of VaultManifestClient. Mitigates #44.
- Update the version of astro from "^4.5.10" to "^4.11.0" - Update the version of sass from "^1.72.0" to "^1.77.6" - Update the version of sharp from "^0.33.3" to "^0.33.4"
The site URL has been updated to 'https://moltenobsidian.dev' and the base URL has been changed to '/'. This ensures that the website is correctly configured for deployment.
This commit improves the handling of the routing table in the `VaultManifestClient` class. - Imporved support for index files (`index.md`, `readme.md`) in the routing table - Fixed a bug where index file was duplicated on root
- Refactored the code to improve the detection of active links in the NavLink component. - Added support for detecting index notes and vault folder titles as active links. - Normalized the path detection by removing leading slashes and optional "index" or "readme" suffixes on index notes
The code change removes the unnecessary assignment of props in the BaseHead component. The defaultProps object is now directly destructured to retrieve the title and description values. This simplifies the code and improves readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.