Skip to content

Use UInt8Array instead of a Buffer for coinbase in ProviderConfig#752

Closed
IftequarIffu wants to merge 1 commit intoNomicFoundation:feat/multichainfrom
IftequarIffu:refactor/replace-buffer-with-uint8array
Closed

Use UInt8Array instead of a Buffer for coinbase in ProviderConfig#752
IftequarIffu wants to merge 1 commit intoNomicFoundation:feat/multichainfrom
IftequarIffu:refactor/replace-buffer-with-uint8array

Conversation

@IftequarIffu
Copy link
Copy Markdown

This PR fixes #746

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 6f5c847

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no changes on the Rust side to change the data size which would invalidate code generation of the index.d.ts and potentially introduce UB.

The investigation is meant to investigate a refactir on the Rust side

@Wodann Wodann deleted the branch NomicFoundation:feat/multichain April 23, 2025 16:09
@Wodann Wodann closed this Apr 23, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants