Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check test task options before passing on noCompile flag #6143

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

galargh
Copy link
Member

@galargh galargh commented Jan 14, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

As @fvictorio rightly pointed out in #5870 (comment), we shouldn't have removed the noCompile flag from the test solidity task as all the "test" tasks are expected to have it implemented.

In this PR, I remove that expectation by adding a options.has("noCompile") check to the parent test task.

@galargh galargh requested a review from alcuadrado January 14, 2025 15:39
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:30pm

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: ac5c280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 14, 2025
@alcuadrado
Copy link
Member

I think we should probably explore fixing the issue that franco raised instead.

@galargh galargh changed the title chore: restore the --no-compile flag in the test solidity task chore: check test task options before passing on noCompile flag Jan 14, 2025
@galargh galargh added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Jan 16, 2025
@galargh galargh added this pull request to the merge queue Jan 16, 2025
Merged via the queue into v-next with commit 1e591a6 Jan 16, 2025
55 checks passed
@galargh galargh deleted the test-solidity-no-compile branch January 16, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants