Skip to content

Don't open connection with loop for python 3.10 #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdczaplicki wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't open connection with loop for python 3.10 #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd7b356
Don't open connection with loop for python 3.10
mdczaplicki Nov 15, 2021
191d6f9
Make unix connection not pass loop
mdczaplicki Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions aredis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,21 @@ def __init__(self, host='127.0.0.1', port=6379, password=None,
self.socket_keepalive_options = socket_keepalive_options or {}

async def _connect(self):
if LOOP_DEPRECATED:
connection = asyncio.open_connection(
host=self.host,
port=self.port,
ssl=self.ssl_context
)
else:
connection = asyncio.open_connection(
host=self.host,
port=self.port,
ssl=self.ssl_context,
loop=self.loop
)
reader, writer = await exec_with_timeout(
asyncio.open_connection(host=self.host,
port=self.port,
ssl=self.ssl_context,
loop=self.loop),
connection,
self._connect_timeout,
loop=self.loop
)
Expand Down Expand Up @@ -642,10 +652,19 @@ def __init__(self, path='', password=None,
}

async def _connect(self):
if LOOP_DEPRECATED:
connection = asyncio.open_unix_connection(
path=self.path,
ssl=self.ssl_context
)
else:
connection = asyncio.open_unix_connection(
path=self.path,
ssl=self.ssl_context,
loop=self.loop
)
reader, writer = await exec_with_timeout(
asyncio.open_unix_connection(path=self.path,
ssl=self.ssl_context,
loop=self.loop),
connection,
self._connect_timeout,
loop=self.loop
)
Expand Down