Skip to content

noresm3_0_025_cam6_4_121: Re-introduce the Bennartz mg diagnostics#250

Merged
gold2718 merged 3 commits intoNorESMhub:noresm_developfrom
Ovewh:diagnostics/beernartz_cdnc
Jan 28, 2026
Merged

noresm3_0_025_cam6_4_121: Re-introduce the Bennartz mg diagnostics#250
gold2718 merged 3 commits intoNorESMhub:noresm_developfrom
Ovewh:diagnostics/beernartz_cdnc

Conversation

@Ovewh
Copy link
Collaborator

@Ovewh Ovewh commented Dec 19, 2025

Re-introduction of few diagnostics in the microphysics

Some diagnostics in the microphysics did not make it through the pumas microphysics update. This PR re-introduces those diagnostics (the Bennartz mg diagnostics CCN_B, ACTNL_B and FCTL_B).

Contributors: @Ovewh

Reviewers: @gold2718 @oyvindseland

Changes made to build system: None

Changes made to the namelist: None

Changes to the defaults for the boundary datasets: None

Substantial timing or memory changes: None

Non-answer changing

@oyvindseland
Copy link

oyvindseland commented Dec 19, 2025

The coding in NorESM2 for these variables may not have been done properly. The output fields will pass a monthly restart test, but does it also pass a daily restart test for these fields?

Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculations need some work.

@gold2718 gold2718 added the enhancement New feature or request label Dec 19, 2025
@github-project-automation github-project-automation bot moved this to In Progress in NorESM Development Dec 19, 2025
@gold2718 gold2718 added this to the noresm3_0_beta10 milestone Dec 19, 2025
@gold2718
Copy link

gold2718 commented Dec 19, 2025

The coding in NorESM2 for these variables may not have been done properly. The output fields will pass a monthly restart test, but does it also pass a daily restart test for these fields?

We can find out for sure when we run tests (if we add history_amwg = .true. to at least one test which I think we should) but I do not see why these fields should not pass once the coding errors are fixed.

@oyvindseland
Copy link

I am afraid that will have to be in early January so at the moment it can be added to aerocom if it is expensive

Fixed issues with mixing of variables defined of different sets of columns.
@Ovewh Ovewh requested a review from gold2718 January 12, 2026 14:32
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks.
I would like one more change to move computation into the hist_field_active logic.

… calculate ncal_grid based on subcolumn usage
@Ovewh Ovewh requested a review from gold2718 January 28, 2026 09:29
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thanks for the cleanup.

@gold2718 gold2718 merged commit 85eb494 into NorESMhub:noresm_develop Jan 28, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in NorESM Development Jan 28, 2026
@gold2718 gold2718 changed the title re-introduce the Bennartz mg diagnostics CCN_B ACTNL_B and FCTL_B noresm3_0_025_cam6_4_121: Re-introduce the Bennartz mg diagnostics Jan 28, 2026
@gold2718
Copy link

Tagged as noresm3_0_025_cam6_4_121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants