Skip to content

Nbp with product pool fluxes.#147

Merged
maritsandstad merged 4 commits intoNorESMhub:noresmfrom
rosiealice:nbp_with_products
Jun 20, 2025
Merged

Nbp with product pool fluxes.#147
maritsandstad merged 4 commits intoNorESMhub:noresmfrom
rosiealice:nbp_with_products

Conversation

@rosiealice
Copy link
Collaborator

@rosiealice rosiealice commented Jun 18, 2025

Description of changes

Updated co2 flux when fates is on.

Includes nbp calculations:
NBP=NPP-fire_closs-grazing_closs-product_loss
Net carbon exchange is positive to atm.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
All aux_clm_noresm tests pass.

(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@rosiealice rosiealice changed the base branch from master to noresm June 18, 2025 09:51
@rosiealice rosiealice changed the title Nbp with product pool fluxes. noresm Nbp with product pool fluxes. Jun 18, 2025
@rosiealice
Copy link
Collaborator Author

@maritsandstad @kjetilaas I think this PR is ready to be merged, but as I am feeling both a little dizzy and kindof on shaky ground with this tagging business, I wondered if one of you could take a look at it? I'm up to the point where it needs merging (see the notes I made in the discussion for the other PR here) following which the final stage is to make a push a ctsm tag and then the new noresm tag.

The other thing, as I noted, is that the product pool variable here is in the soilbgc rather than the fates interface - I had forgotten in my delirium that Matvey suggested i should do that. But in order to avoid getting any sicker I am cutting my losses here and tidying it up will need to be TBD (sorry!)

@maritsandstad
Copy link
Collaborator

Happy to look at this later today/this afternoon. Just relax and get better @rosiealice

@maritsandstad maritsandstad mentioned this pull request Jun 20, 2025
@maritsandstad
Copy link
Collaborator

Can't push to your branch, and probably can't merge in there either so I am fixing the rest of this here: #148

@maritsandstad maritsandstad merged commit 6468961 into NorESMhub:noresm Jun 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants