Skip to content

Documentation - #49

Merged
Laura2305 merged 7 commits into
mainfrom
Documentation
Apr 23, 2024
Merged

Documentation#49
Laura2305 merged 7 commits into
mainfrom
Documentation

Conversation

@Laura2305

Copy link
Copy Markdown
Contributor
  • Update documentation (on Siemens data concatenation = 1 is required).
  • Add test data link.

@Laura2305
Laura2305 marked this pull request as draft February 28, 2024 08:36
@codecov

codecov Bot commented Feb 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (34801ec) to head (814b177).
Report is 5 commits behind head on main.

❗ Current head 814b177 differs from pull request most recent head 229e581. Consider uploading reports for the commit 229e581 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files           9        9           
  Lines         620      620           
=======================================
  Hits          440      440           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laura2305
Laura2305 force-pushed the Documentation branch 4 times, most recently from 612336e to 4c7fb09 Compare February 28, 2024 22:04
@Laura2305
Laura2305 marked this pull request as ready for review March 1, 2024 14:18
@Laura2305
Laura2305 requested a review from alexjaffray March 1, 2024 14:18
@Laura2305 Laura2305 mentioned this pull request Mar 11, 2024

@alexjaffray alexjaffray left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the test/.DS_Store file, otherwise approved!

Comment thread test/.DS_Store

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be here? I think it's a hidden file that made it's way in.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexjaffray it's a hidden file used by Mac finder. There's no reason for it to be in the GitHub folder.

@Laura2305
Laura2305 merged commit c908527 into main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants