FIX: audit 1f602 commit 3, wordToBytesCanonical added to src/sha/util… - #65
Merged
Conversation
…s.ts as a sound sibling of wordToBytes for bytesPerWord > 31, backed by new isCanonicalFieldBytesLE range check against FIELD_PRIME_LE, both exported from src/index.ts and src/index.min.ts alongside wordToBytes, regression tests added proving the canonicity check rejects forged p and p+1 byte arrays that satisfy the old mod-p equality alone, all regression tests pass (11 pass 0 fail), changelog/readme updated.
Kirol54
approved these changes
Aug 20, 2026
Quality Gate ReportGenerated: 8/20/2026, 2:11:05 PM Overall Status: FAILRequired checks failed:
Summary
Detailed ResultsDependencies - PASSType: REQUIRED Message: Dependencies installed successfully Scripts Check - FAILType: Optional Message: Missing scripts: test:unit, test:integration Detailsnpm audit - FAILType: REQUIRED Message: Vulnerabilities found (threshold: moderate) Hint: DetailsBuild - PASSType: REQUIRED Message: Build completed successfully Prettier - FAILType: Optional Message: 63 file(s) need formatting Hint: Linter - FAILType: Optional Message: 21 error(s), 0 warning(s) Hint: DetailsUnit Tests - SKIPPEDType: Info Message: test:unit script not found Actionable Insights
ConfigurationQuality gate configured via environment variables.
Note: Integration and E2E tests are checked for existence but run in CI/CD pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s.ts as a sound sibling of wordToBytes for bytesPerWord > 31, backed by new isCanonicalFieldBytesLE range check against FIELD_PRIME_LE, both exported from src/index.ts and src/index.min.ts alongside wordToBytes, regression tests added proving the canonicity check rejects forged p and p+1 byte arrays that satisfy the old mod-p equality alone, all regression tests pass (11 pass 0 fail), changelog/readme updated.