Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23208: Add a warning in the logs when using local auth with non-bcrypt passwords #4944

Draft
wants to merge 2 commits into
base: branches/rudder/8.0
Choose a base branch
from
Draft

Fixes #23208: Add a warning in the logs when using local auth with non-bcrypt passwords #4944

wants to merge 2 commits into from

Conversation

amousset
Copy link
Member

@amousset amousset commented Aug 2, 2023 •
edited
Loading

https://issues.rudder.io/issues/23208

  • Remove the ability to use the fallback admin account with a clear text password in config
  • Add a warn log when local users use an unsafe storage

@amousset amousset requested a review from fanf August 2, 2023 21:58
@amousset amousset marked this pull request as draft August 2, 2023 21:59
@amousset
fixup! Fixes #23208: Add a warning in the logs when using local auth …
387aefe 
…with non-bcrypt passwords

Fixes #23208: Add a warning in the logs when using local auth with non-bcrypt passwords
@amousset
Copy link
Member Author

amousset commented Aug 3, 2023

PR updated with a new commit

fanf
fanf reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could already have the warning even if the health check is not satisfaying ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amousset @fanf