Skip to content

156 - Finished implementing HSL to Thermometer Coloring#160

Open
Kavinraj-J wants to merge 4 commits intodevelopfrom
156-thermometer---thermometer-coloring-should-use-hsl
Open

156 - Finished implementing HSL to Thermometer Coloring#160
Kavinraj-J wants to merge 4 commits intodevelopfrom
156-thermometer---thermometer-coloring-should-use-hsl

Conversation

@Kavinraj-J
Copy link

Changes

Finished implementing the HSL coloring of the thermometers. Switched it from the previous 5-stage coloring system

Notes

_HSL color range hue goes from 0-290 _
Made an intended change to the CmakeList.txt file

Screenshots

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #156

@bracyw bracyw assigned Kavinraj-J and unassigned bracyw Oct 27, 2025
@bracyw bracyw self-requested a review October 27, 2025 20:55
@Kavinraj-J
Copy link
Author

Changes

Finished implementing the HSL coloring of the thermometers. Switched it from the previous 5-stage coloring system

Notes

Color Ranges
0-12.5% (-15° to -5°): Purple → Blue
12.5-25% (-5° to 5°): Blue → Cyan
25-37.5% (5° to 15°): Cyan → Green
37.5-50% (15° to 25°): Green → Yellow
50-75% (25° to 45°): Yellow → Orange
75-87.5% (45° to 55°): Orange → Red
87.5-100% (55° to 65°): Red

Screenshots

Original Coloring:

image

Updated Coloring:

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #156

Copy link
Contributor

@bracyw bracyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix merge conflicts and we should be good

bracyw
bracyw previously approved these changes Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Thermometer] - thermometer coloring should use hsl

3 participants