161 - Finished Displaying Regen as a Percentage of Total Capacity#163
Open
devmchechi wants to merge 11 commits intodevelopfrom
Open
161 - Finished Displaying Regen as a Percentage of Total Capacity#163devmchechi wants to merge 11 commits intodevelopfrom
devmchechi wants to merge 11 commits intodevelopfrom
Conversation
added 2 commits
November 7, 2025 18:44
bracyw
previously requested changes
Nov 17, 2025
Contributor
bracyw
left a comment
bracyw
left a comment
There was a problem hiding this comment.
Two questions, otherwise looks good.
devmchechi
commented
Nov 18, 2025
Contributor
Author
devmchechi
left a comment
devmchechi
left a comment
There was a problem hiding this comment.
This needed to be changed because you wanted to make the percentage on the Efficiency screen look like that Torque Percentage. Before the percentage was on the below the number, and smaller. I changed it so the percentage UI looked like the Torque percentage.
devmchechi
dismissed
bracyw’s stale review
This needed to be changed because you wanted to make the percentage on the Efficiency screen look like that Torque Percentage. Before the percentage was on the below the number, and smaller. I changed it so the percentage UI looked like the Torque percentage.
…ty' of https://github.com/Northeastern-Electric-Racing/Nero-2.0 into 161-task--display-regen-as-a-percentage-of-total-capacity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In the EfficiencyScreen and SpeedScreen, I added booleans to go back and forth between amps and percentage. I added variables and functions to initialize the maxRegenCapacity and calculate the percentage of regen.
Screenshots
Performance Screen:
Efficiency Screen:
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes 161