Merge pull request #81 from NorthernOceanS/issue78

Don't rewrite plugins.json if it isn't modified and fix other bugs.
NorthernOceanS · Jul 27, 2021 · b63f025 · b63f025
2 parents c6b1947 + 2c7cad5
commit b63f025
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/file-generation.js b/file-generation.js
@@ -111,15 +111,21 @@ class AutoFileGenerationSupport {
 				if(havePluginJsSync()) {
 					return packDone();
 				}
-				let pluginJSON = getPluginsJSONSync() || {};
+				let pluginJSON = getPluginsJSONSync();
 				let pluginDirs = getPluginDirsSync();
+				let isModified = false;
+				if(pluginJSON === null) {
+					pluginJSON = {};
+					isModified = true;
+				}
 				for(let dirName of pluginDirs) {
 					if(pluginJSON[dirName] === undefined) {
 						console.log(`Add dir ${dirName}`);
 						pluginJSON[dirName] = {
 							type: "inner",
 							enable: true
 						};
+						isModified = true;
 					}
 				}
 				let pluginJs = `
@@ -149,15 +155,11 @@ class AutoFileGenerationSupport {
 						break;
 					}
 				}).join('');
-				if(this.writeBack) {
-					console.log(path.join(
-						sourceDir,
-						'scripts/plugin/plugins.json'
-					), JSON.stringify(pluginJSON, null, '\t'));
+				if(this.writeBack && isModified) {
 					fs.writeFileSync(path.join(
 						sourceDir,
 						'scripts/plugin/plugins.json'
-					), JSON.stringify(pluginJSON, null, '\t'));
+					), JSON.stringify(pluginJSON, null, '\t').concat('\n'));
 				}
 				fs.writeFileSync(path.join(
 					destination,

diff --git a/packs/behaviors/manifest.json b/packs/behaviors/manifest.json
@@ -7,7 +7,7 @@
     "version": [
       0,
       13,
-      13
+      14
     ]
   },
   "modules": [