Fix: sync even if the user has no groups (to remove roles the user had)#2
Open
pierrearma wants to merge 4 commits intoNotActuallyTerry:masterfrom
Open
Fix: sync even if the user has no groups (to remove roles the user had)#2pierrearma wants to merge 4 commits intoNotActuallyTerry:masterfrom
pierrearma wants to merge 4 commits intoNotActuallyTerry:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user logs in and has a single role. The plugin adds his role.
Suppose the user loses his role and no longer has one. The plugin won't synchronize, but it should delete a role.
This fix the issue.
I don't know if this is the best way to do it. But I needed to do it on my own, so I'm sharing.