Repository navigation
Implement user profile page and enhance API handling - #11
Merged
Merged
Conversation
… cache version and adjust API handling
🧪 Test coverage |
…rofile fetching and discussion filtering
… and outline security policies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces user profile pages and improves internal linking to user profiles throughout the app. It also adds new API methods and types to support profile data, and makes several enhancements to how data is fetched and rendered.
User Profile Pages and API Support:
getUserProfileandlistUserDiscussionsfunctions, theUserProfileandProfileCommenttypes, and logic to filter and validate profile data from the GitHub API. [1] [2] [3]Internal Linking Improvements:
CommentCard.svelte,DiscussionRow.svelte,Header.svelte, and discussion pages to use internal routes (/u/[login]) instead of linking directly to GitHub, improving navigation and consistency. [1] [2] [3] src/routes/d/[number]/+page.svelteL226-R226)API Enhancements and Robustness:
gql) to optionally tolerateNOT_FOUNDerrors, allowing partial data to be returned when some profile fields are missing (e.g., missing profile README). [1] [2]renderMarkdownAPI to support bothgfmandmarkdownmodes and accept context options, ensuring correct rendering for both comments and profile READMEs. [1] [2]Caching and Data Consistency:
cache.tsto invalidate outdated cache entries due to changes in the shape of cached GraphQL data.Type and Data Model Updates:
DiscussionListItemand related structures to include repository information, supporting more robust filtering and validation of profile-related data.These changes collectively enable user profile pages with accurate forum activity, improve navigation, and make the data layer more robust and maintainable.