feat: fix things with candy

NotionX · Oct 31, 2024 · f2b21cf · f2b21cf
1 parent 3aa300c
commit f2b21cf
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 32 deletions.
diff --git a/examples/cra/package.json b/examples/cra/package.json
@@ -3,10 +3,10 @@
   "version": "6.16.1",
   "private": true,
   "scripts": {
-    "dev": "GENERATE_SOURCEMAP=false react-scripts start",
-    "start": "GENERATE_SOURCEMAP=false react-scripts start",
-    "build": "GENERATE_SOURCEMAP=false react-scripts build",
-    "eject": "GENERATE_SOURCEMAP=false react-scripts eject"
+    "dev": "DISABLE_ESLINT_PLUGIN=true GENERATE_SOURCEMAP=false react-scripts start",
+    "start": "DISABLE_ESLINT_PLUGIN=true GENERATE_SOURCEMAP=false react-scripts start",
+    "build": "DISABLE_ESLINT_PLUGIN=true GENERATE_SOURCEMAP=false react-scripts build",
+    "eject": "DISABLE_ESLINT_PLUGIN=true GENERATE_SOURCEMAP=false react-scripts eject"
   },
   "dependencies": {
     "@types/node": "^22.8.4",
@@ -18,12 +18,6 @@
     "react-notion-x": "workspace:*",
     "react-scripts": "5.0.1"
   },
-  "eslintConfig": {
-    "extends": [
-      "react-app",
-      "react-app/jest"
-    ]
-  },
   "browserslist": {
     "production": [
       ">0.2%",

diff --git a/examples/cra/src/App.tsx b/examples/cra/src/App.tsx
@@ -1,4 +1,4 @@
-import { ExtendedRecordMap } from 'notion-types'
+import { type ExtendedRecordMap } from 'notion-types'
 import { NotionRenderer } from 'react-notion-x'
 import { Code } from 'react-notion-x/build/third-party/code'
 import { Collection } from 'react-notion-x/build/third-party/collection'

diff --git a/examples/cra/src/index.tsx b/examples/cra/src/index.tsx
@@ -1,19 +1,14 @@
-import * as React from 'react'
-
-import * as ReactDOM from 'react-dom'
 // core styles shared by all of react-notion-x (required)
 import 'react-notion-x/src/styles.css'
-
-import App from './App'
 // used for code syntax highlighting (optional)
 // import 'prismjs/themes/prism-tomorrow.css'
 // used for rendering equations (optional)
 // import 'katex/dist/katex.min.css'
 import './index.css'
 
-ReactDOM.render(
-  <React.StrictMode>
-    <App />
-  </React.StrictMode>,
-  document.getElementById('root')
-)
+import { createRoot } from 'react-dom/client'
+
+import App from './App'
+
+const root = createRoot(document.getElementById('root')!)
+root.render(<App />)
diff --git a/packages/react-notion-x/package.json b/packages/react-notion-x/package.json
@@ -16,24 +16,24 @@
       "import": "./build/index.js"
     },
     "./build/third-party/code": {
-      "types": "./build//third-party/code.d.ts",
-      "import": "./build//third-party/code.js"
+      "types": "./build/third-party/code.d.ts",
+      "import": "./build/third-party/code.js"
     },
     "./build/third-party/collection": {
-      "types": "./build//third-party/collection.d.ts",
-      "import": "./build//third-party/collection.js"
+      "types": "./build/third-party/collection.d.ts",
+      "import": "./build/third-party/collection.js"
     },
     "./build/third-party/equation": {
-      "types": "./build//third-party/equation.d.ts",
-      "import": "./build//third-party/equation.js"
+      "types": "./build/third-party/equation.d.ts",
+      "import": "./build/third-party/equation.js"
     },
     "./build/third-party/modal": {
-      "types": "./build//third-party/modal.d.ts",
-      "import": "./build//third-party/modal.js"
+      "types": "./build/third-party/modal.d.ts",
+      "import": "./build/third-party/modal.js"
     },
     "./build/third-party/pdf": {
-      "types": "./build//third-party/pdf.d.ts",
-      "import": "./build//third-party/pdf.js"
+      "types": "./build/third-party/pdf.d.ts",
+      "import": "./build/third-party/pdf.js"
     },
     "./styles.css": "./src/styles.css",
     "./src/styles.css": "./src/styles.css"