2fa: Initial setup #386
Draft
2fa: Initial setup #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpslwk
force-pushed
the
#355-2fa
branch
2 times, most recently
from
c225e03
to
b7cf307
Compare
TODO: * update views (inc text view of generated key for manual input) * allow secrete regeneration * allow recovery * allow admin to force disable on a users account (for recovery) * tie into roles
# Conflicts: # app/Http/Controllers/Api/SearchController.php # resources/js/select2.js # routes/web.php
User: give google2fa a default
has to fix up UserFactory to give google2faEnable a default and fix a bunch of other bits this replaces `dev/reeseed.sh` with `php artisan hms:reseed`
# Conflicts: # resources/views/layouts/app.blade.php
# Conflicts: # app/HMS/Entities/User.php # app/Http/Kernel.php
dpslwk
force-pushed
the
#355-2fa
branch
2 times, most recently
from
b420222
to
c4e8fd3
Compare
This forces us to take GB numbers and then we store them in e164 ready for nexmo fix #210
# Conflicts: # app/HMS/User/ProfileManager.php # app/HMS/User/UserManager.php # app/Http/Controllers/MembershipController.php # app/Http/Kernel.php # resources/views/layouts/navbar.blade.php # routes/web.php
# Conflicts: # routes/console.php # routes/web.php
# Conflicts: # Vagrantfile # composer.json # composer.lock # resources/views/layouts/navbar.blade.php # routes/console.php
|
check if 873b34b has fixed what I had thought was an ACL BootChain issue |
dpslwk
force-pushed
the
main
branch
3 times, most recently
from
d03e21e
to
c0e2557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
close #355