fix(mcp): coerce JSON string params to native types + skip utility tools for unsupported servers#3690
Open
ygd58 wants to merge 2 commits intoNousResearch:mainfrom
Open
fix(mcp): coerce JSON string params to native types + skip utility tools for unsupported servers#3690ygd58 wants to merge 2 commits intoNousResearch:mainfrom
ygd58 wants to merge 2 commits intoNousResearch:mainfrom
Conversation
Contributor
Author
|
The test failure is a pre-existing CI issue — a skill invocation test checks for a specific string that was reworded in a prior commit. Not related to this PR's changes to tools/mcp_tool.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3682
Fix 1: JSON string coercion
LLMs emit array/boolean/number params as JSON-encoded strings. Added _coerce_json_strings() that converts these to native types before call_tool().
Fix 2: gitmcp utility tool discovery
hasattr(server.session, method) always returns True even when transport returns "Method not found". Now checks server_info.capabilities before registering list_resources/list_prompts tools.