fix: use constant-time comparison for API key validation in ApiServer…#3697
Closed
memosr wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: use constant-time comparison for API key validation in ApiServer…#3697memosr wants to merge 1 commit intoNousResearch:mainfrom
memosr wants to merge 1 commit intoNousResearch:mainfrom
Conversation
…Adapter _check_auth() compared the Bearer token with == which is not constant-time. An attacker with network access to the API server could measure response latency to enumerate the API key one character at a time (timing side-channel attack). Fix uses hmac.compare_digest() which is guaranteed to run in constant time regardless of where the strings first differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Adapter
_check_auth() compared the Bearer token with == which is not constant-time. An attacker with network access to the API server could measure response latency to enumerate the API key one character at a time (timing side-channel attack).
Fix uses hmac.compare_digest() which is guaranteed to run in constant time regardless of where the strings first differ.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs