fix: replace print() with logger in HookRegistry#3701
Closed
memosr wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: replace print() with logger in HookRegistry#3701memosr wants to merge 1 commit intoNousResearch:mainfrom
memosr wants to merge 1 commit intoNousResearch:mainfrom
Conversation
HookRegistry used 7 print() calls but never imported logging. This means hook lifecycle events and errors go to stdout instead of the gateway's structured log output. Most critically, the emit() handler error at line 151 was using print() which silently discards the full traceback. A misbehaving hook that raises an unexpected exception would show only the exception message with no stack trace, making debugging nearly impossible. Changes: - Add import logging and module-level logger = logging.getLogger(__name__) - Hook skip warnings → logger.warning() - Hook load success → logger.info() - Hook load error → logger.error(exc_info=True) to capture traceback - Hook emit error → logger.exception() which always captures full traceback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HookRegistry used 7 print() calls but never imported logging. This means hook lifecycle events and errors go to stdout instead of the gateway's structured log output.
Most critically, the emit() handler error at line 151 was using print() which silently discards the full traceback. A misbehaving hook that raises an unexpected exception would show only the exception message with no stack trace, making debugging nearly impossible.
Changes:
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs