Skip to content

Fix Home Assistant device event cooldown and state descriptions - #240

Closed
vortexopenclaw wants to merge 3 commits into
NousResearch:mainfrom
vortexopenclaw:fix/homeassistant-device-event-correctness
Closed

vortexopenclaw wants to merge 3 commits into
NousResearch:mainfrom
vortexopenclaw:fix/homeassistant-device-event-correctness

Conversation

@vortexopenclaw

Copy link
Copy Markdown
Contributor

Title: Fix Home Assistant device event cooldown and state descriptions

Summary

  • Start per-entity cooldown only after an event produces a message, so no-op events cannot suppress the next meaningful transition.
  • Preserve actual unknown/unavailable transitions for switches, lights, fans and binary sensors instead of describing them as off or cleared.
  • Describe attribute-only climate changes to current temperature, target temperature and target temperature range while ignoring unrelated attribute changes.

Verification

  • Added 22 synthetic regression cases; before the production fix: 17 failed, 5 passed.
  • Complete Home Assistant suite: 158 passed, 1 skipped using an isolated test home and the current installed Hermes core checkout with isolated aiohttp/pytest dependencies.
  • git diff --check passed.

Scope

Only the Home Assistant adapter and synthetic device-event regression tests are changed. No configuration, captured device data, backups, or unrelated changes are included.

@teknium1 teknium1 added the needs-decision Awaiting an owner policy or product decision label Nov 19, 2026
teknium1 added a commit that referenced this pull request Nov 20, 2026
…t an event

#240 made current_temperature an attribute-only climate trigger. A thermostat
reports it on every reading, so a watched climate entity would wake the agent
over and over. Setpoint changes (temperature, target_temp_low/high) still
trigger.
@teknium1

Copy link
Copy Markdown
Contributor

Thank you @vortexopenclaw! This landed on main through #451, without the current_temperature trigger for watched climate entities (it would start an agent turn on every room-temperature tick), with your authorship kept; tip fd79186. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

@teknium1 teknium1 closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-decision Awaiting an owner policy or product decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants