Skip to content

fix(mcp-serve): support relocated outbound sender - #456

Open
mvdbastos wants to merge 1 commit into
NousResearch:mainfrom
mvdbastos:fix/mcp-serve-outbound-sender
Open

mvdbastos wants to merge 1 commit into
NousResearch:mainfrom
mvdbastos:fix/mcp-serve-outbound-sender

Conversation

@mvdbastos

Copy link
Copy Markdown

Summary

Fixes #454.

Hermes moved its outbound sender from tools.send_message_tool to gateway.outbound.send in NousResearch/hermes-agent#156512. The MCP bridge still imported the old path, causing messages_send to return Send message tool not available on current Hermes versions.

  • Prefer the current sender import, with a fallback to the legacy path when the new module is absent.
  • Do not fall back when a dependency inside the current sender is missing; include import error details in the response instead.
  • Add regression coverage for current and legacy layouts and missing sender dependencies.

Both paths are private core imports; a supported public messaging API would provide a more durable integration when available.

Verification

  • Five standalone checks passed against the checked-out plugin and current Hermes runtime, including simulated legacy and missing-dependency cases.
  • Called messages_send through the real MCP server API with the sender mocked; verified the response and dispatched arguments. No real message was sent.
  • git diff --check passed.
  • The pytest suite was not run: pytest was not installed in the managed Hermes environment. The new pytest regression tests are included but have not yet been executed with pytest.

@mvdbastos
mvdbastos requested a review from teknium1 as a code owner November 20, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp-serve messages_send fails after outbound sender module relocation

1 participant