Merged
Conversation
This reverts commit 04673d2.
unit0016
approved these changes
Sep 4, 2025
Contributor
unit0016
left a comment
There was a problem hiding this comment.
approving half because you're the last active headmin and half because it's really funny that our last PR in forever gets reverted within the day
Contributor
|
This is halarious, however the issue lies in the fact its a noble assistant role and while its been beefed up in the code to be made extremely appealing, it has no access to areas that would provide progress to the role, such as the steward's shack or the vault. while we are a roleplay server we should also consider that there are mechanics that need to happen, especially for town roles needing imports to function, which helps others reach a state of being able to not focus on mechanics and reach a state of being able to roleplay in their own elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts NovaSector/Solaris#360
This PR is to revert the Noble RCP drop with the rationale below.
Reducing RCP for nobles feels more like a punishment to the players who may enjoy the role rather than anything legitimate that will force people to play other roles. 3 RCP would still require a good chunk of rounds to equate to 1 PQ (Should be 4 if the ratio of RCP to PQ is still 10 to 1. THat effectively makes it from 4 rounds to 10, effectively doubling it for what is already a very small amount of PQ, especially when RCP does have a cap out limit too. In rounds that do have population and no Marquis present, that does make them one of the prospective leaders until the position is filled. 1 RCP sets it lower than any other possible role available for no solid grounded reason that can be said enhances the experience, nor would this incentivize people to bloom out to other roles if it is outside of their preferences, or what realistically would be something an established character would already do. If RCP was the main incentive for playing a role, bandits would be occupied heavily due to the 5 RCP given each round.