fix: stucked byte range requests#462
Merged
DimaDemchenko merged 3 commits intoNovage:mainfrom Feb 6, 2025
Merged
Conversation
Due to an invalid check, the request throws even if it is valid. `total` from `parseContentRangeHeader` is the total amount of bytes of the stream but `totalBytes` from `request` is the total amount of bytes of the request that we can infer from `to` and `from`
mrlika
approved these changes
Feb 5, 2025
DimaDemchenko
requested changes
Feb 6, 2025
Contributor
DimaDemchenko
left a comment
DimaDemchenko
left a comment
There was a problem hiding this comment.
Hi @Chocobozzz,
Thank you for reporting this bug! We have found a better way to validate the contentRange from the response. Could you please update your PR accordingly?
Co-authored-by: Dmytro Demchenko <ipz215_ddo@student.ztu.edu.ua>
Co-authored-by: Dmytro Demchenko <ipz215_ddo@student.ztu.edu.ua>
Contributor
Author
|
Sure! It's done. You can squash the PR or I can do it manually if you prefer |
DimaDemchenko
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an invalid check, the request throws even if it is valid.
totalfromparseContentRangeHeaderis the total amount of bytes of the stream buttotalBytesfromrequestis the total amount of bytes of the request that we can infer fromtoandfrom