Fix side panel top and bottom empty space #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify DOM structure of the offcanvas side panel, reducing a previously redundant level of `<div>`. - Fix extra white spaces existing above and below the side panel list in some themes such as Oblivion. - Define container background color and border color using variables, which are applied to the top menu, the side panel, and the list table.
jevenski
commented
Nov 15, 2024
Comment on lines
+140
to
+176
| <div class="p-1 p-md-0 offcanvas-body"> | ||
| <template id="panel-label-template"> | ||
| <link href="./css/panel-label.css?v=51B4" rel="stylesheet" type="text/css" /> | ||
| <div part="prefix" hidden></div> | ||
| <div part="icon"></div> | ||
| <div part="text"></div> | ||
| <div part="count">0</div> | ||
| <div part="size" style="display: none;"></div> | ||
| </template> | ||
| <template id="category-panel-template"> | ||
| <link href="./css/category-panel.css?v=51B4" rel="stylesheet" type="text/css" /> | ||
| <div part="heading"> | ||
| <span class="text"></span><slot name="decorator" class="decorator"></slot> | ||
| </div> | ||
| <slot name="content"></slot> | ||
| </template> | ||
| <category-list id="CatList"> | ||
| <category-panel id="pview" uilangtext="pnlViews"> | ||
| <input slot="decorator" class="Button" type="button" value="+" uilangtitle="SaveCurrentView" id="pview_save_view_button" /> | ||
| <panel-label id="pview_all" icon="all" uilangtext="All" selected></panel-label> | ||
| </category-panel> | ||
| <category-panel id="pstate" uilangtext="pnlState"> | ||
| <panel-label id="pstate_all" icon="all" uilangtext="All" selected></panel-label> | ||
| <panel-label id="-_-_-dls-_-_-" icon="down" uilangtext="Downloading"></panel-label> | ||
| <panel-label id="-_-_-com-_-_-" icon="completed" uilangtext="Finished"></panel-label> | ||
| <panel-label id="-_-_-act-_-_-" icon="up-down" uilangtext="Active"></panel-label> | ||
| <panel-label id="-_-_-iac-_-_-" icon="inactive" uilangtext="Inactive"></panel-label> | ||
| <panel-label id="-_-_-err-_-_-" icon="error" uilangtext="Error"></panel-label> | ||
| </category-panel> | ||
| <category-panel id="plabel" uilangtext="Labels"> | ||
| <panel-label id="plabel_all" icon="all" uilangtext="All" selected></panel-label> | ||
| <panel-label id="-_-_-nlb-_-_-" icon="no-label" uilangtext="No_label"></panel-label> | ||
| </category-panel> | ||
| <category-panel id="psearch" uilangtext="mnu_search"> | ||
| <panel-label id="psearch_all" icon="all" uilangtext="All" selected></panel-label> | ||
| </category-panel> | ||
| </category-list> |
There was a problem hiding this comment.
Other than reducing one tab indent because of the removal of the redundant level of <div>, these lines are unchanged. Also some verbose bootstrap utility class names were removed from the .offcanvas-body element.
|
Background below the side panel list is different desktop and mobile. mobile (left) desktop (right) Standard Acid Blue DarkBetter Excel MaterialDesign Oblivion |
|
Looks great! mobile (left) desktop (right) Standard Acid Blue DarkBetter Excel MaterialDesign Oblivion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After - Empty spaces are now gone:
With the aim of fixing empty spaces above/below the panel list in Oblivion and MaterialDesign themes, this patch also simplifies the DOM structure of the side panel, and replaces part of hard-coded color schemes with CSS variables.
<div>.