Adjust top navbar styles and behaviors #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a sizing issue in MaterialDesign theme. - Restore original navbar styles (background image and color), and unify styles of navbar items. The new implementation tries to resemble the old look of ruTorrent, while utilizing CSS variables. This philosophy helps remove code duplication. Some background images are also replaced by CSS gradient. - Auto close collapsible top navbar when resizing and/or opening a dialog window. This adds slightly to ease of use, and prevent styling issues when switching between different screen resolutions.
|
Image file paths seem to be incorrect
I don't know if this is the intended effect, but the menu blink when ruTorrent is opened
|
|
Looks great! Acid Blue DarkBetter Excel MaterialDesign Oblivion Standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues to be addressed in this patch
1. Navbar background lost from v4.3 (top) to v5.0 (bottom)
The original background image was lost in the following themes. This patch tries to restore the original background, while using a different implementation.
2. A slightly squeezed gap between the main content and the status bar in MaterialDesign theme
BEFORE
AFTER
Commit message