Fix torrent deleted without confirmation #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix torrent deleted without confirmation - This commit fixes an error that torrent(s) get deleted without confirmation, even if the option is checked in the options. Previously, the delete action worked as expected using the delete button in the top menu, asking for confirmation before taking actual action. However, using the "remove" option in the context menu or the `DEL` key on the keyboard would got the torrent(s) removed immediately. They were just not calling the correct remove function. - Besides the correction of delete events handler, two other things were carried out by the way, although not on the scope of the entire app but just around the functions that were adjusted in this fix. 1. Some ident related issues were picked out by the way, like mixing spaces with tabs on the same line. 2. Documentations were added to some of the JS functions, according to my own understanding of the function. They might be incorrect, but can be polished while the project grows.
|
That's cool. It's time we start a new development cycle and add more features to it. |
|
Please submit change to |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jevenski this is your commit from pull request #2724
I removed from original commit part renaming
ndx->keyand this resolved issues with saving column sorting.This should go into v5.2 where we will have more time for testing.