Open
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://NumericalMathematics.github.io/Ariadne.jl/previews/PR128/ in a couple of minutes. |
vchuravy
force-pushed
the
vc/linesearches.jl
branch
from
78ebce1 to
f4bca65
Compare
- Use ‖F‖²/2 as line search objective so dϕ = dot(F, J·d) without division - Compute dϕ via ws.J (JacobianOperator) instead of nested autodiff - Guard against non-descent directions (dϕ₀ ≥ 0) - Add tests for BackTracking, StrongWolfe, MoreThuente on Rosenbrock - Update rosenbrock.jl example with LineSearches.jl section Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vchuravy
force-pushed
the
vc/linesearches.jl
branch
from
f4bca65 to
ea55b8b
Compare
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/linesearches.jl b/src/linesearches.jl
index 0958a2c..8701985 100644
--- a/src/linesearches.jl
+++ b/src/linesearches.jl
@@ -85,7 +85,7 @@ function (ls::BacktrackingLineSearch)(ws, norm_res_prior, d)
return norm_res
end
-struct LineSearches_JL{T<:Any} <: AbstractLineSearch
+struct LineSearches_JL{T <: Any} <: AbstractLineSearch
linesearch::T
end
|
ranocha
reviewed
Apr 22, 2026
Comment on lines
+9
to
+10
| function (ls::LineSearches_JL)(ws, norm_res_prior, d) | ||
| # TODO: avoid allocations in the line by providing a workspace for the line search |
Member
There was a problem hiding this comment.
Do you want to do this in this PR?
Member
|
What are the general results that you get with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.