-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(themes): add missing themes #260
base: v2.5
Are you sure you want to change the base?
Conversation
davimmt
commented
Mar 25, 2024
Related to this theme. |
@davimmt i think it'll be better for us to automate this part! like a github workflow which will update types on push. cuz more themes need to be added https://nvchad.com/news/v2.5_release#new_themes but themes are located in base46 repo! so i think the automation must be added in base46 repo and it'll push to this UI repo's nvchad_types dir |
so i wont merge this yet. same thing needs to be done with the highlight groups |
Just run the generator for that :) |
Agreed. Opened to raise awareness, at minimum. |
this? https://github.com/NvChad/ui/blob/v2.5/scripts/update-nvchad-types.lua So this must be done when staying in nvim itself right? |
or |
Hey, can you confirm this command works on your machine? because on mine it errors out: $ nvim -l scripts/update-nvchad-types.lua
E5113: Error while calling lua chunk: scripts/update-nvchad-types.lua:5: module 'base46' not found:
no field package.preload['base46']
no file './base46.lua'
no file '/usr/share/luajit-2.1/base46.lua'
no file '/usr/local/share/lua/5.1/base46.lua'
no file '/usr/local/share/lua/5.1/base46/init.lua'
no file '/usr/share/lua/5.1/base46.lua'
no file '/usr/share/lua/5.1/base46/init.lua'
no file './base46.so'
no file '/usr/local/lib/lua/5.1/base46.so'
no file '/usr/lib/lua/5.1/base46.so'
no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
[C]: in function 'require'
scripts/update-nvchad-types.lua:5: in main chunk But the require error goes away if I do it from within with |
because base46 is not loaded on startup. |
@KorigamiK what about opening nvim and just running |
@KorigamiK yea didnt work. can you just open nvim and run |
@siduck That's true, I was trying to do this in the command line so I can add this generator to the CI for the repo |
Forgot im running it from a different version :D I think the script should be reworked to be CI-only |