rewind in-memory stream to have expected behaviour (#177)

Nyholm · May 10, 2021 · d937173 · d937173
1 parent 902515f
commit d937173
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file, in reverse chronological order by release.
 
+## Unreleased
+
+### Fixed
+
+- `Stream::create` with a string needs to rewind the created memory stream.
+
 ## 1.4.0
 
 ### Removed

diff --git a/src/Stream.php b/src/Stream.php
@@ -71,6 +71,7 @@ public static function create($body = ''): StreamInterface
         if (\is_string($body)) {
             $resource = \fopen('php://temp', 'rw+');
             \fwrite($resource, $body);
+            \rewind($resource);
             $body = $resource;
         }
 

diff --git a/tests/StreamTest.php b/tests/StreamTest.php
@@ -44,6 +44,13 @@ public function testConvertsToString()
         $stream->close();
     }
 
+    public function testBuildFromString()
+    {
+        $stream = Stream::create('data');
+        $this->assertEquals('data', $stream->getContents());
+        $stream->close();
+    }
+
     public function testGetsContents()
     {
         $handle = fopen('php://temp', 'w+');