-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom headers to email #1079
Conversation
@alejcas what do you think? |
Well I commented your code but you didn’t answer |
I'm sorry, I can't find any other comments except for this one. Where can I find them? If you refer to the comments you made on the older PR that I've linked to, it wasn't made by me and I've tried to implement those suggestions. |
5d8f178
to
dd77f04
Compare
@alejcas what do you think? Thank you! I've updated the code with your suggestion to fix the issue. The reason why I can't see your comment is because it's "Pending", you need to submit it for me to be able to see it. Here is a github issue with lots of people confused about the UX. |
Embarrasing... Review submited Please see the comments |
This to offload from the users the need to know the exact format of the datastructure (having a list of dicts with specific keys).
Thanks! |
Thank you! What is the schedule of releases of this package? I noticed the last version is from februari on pypi. We would love to be able to use this in our application, when do you think it will be available? |
I usually wait until there are a coupe/more improvements on master. Let me check and I’ll report back |
2.0.35 released |
This a continuation on an existing PR #871 , and tries to handle the comments there. Also adding the property before the
restrict_keys
part to not sidestep that functionality.We want to be able to send custom headers to the email, as supported in this example i MS docs.
I added two unit tests to verify the behavior
but I wasn't able to test it with the live environment. I've tested it with my O365-account and I think it works as expected.