Skip to content

Conversation

Daemo00
Copy link

@Daemo00 Daemo00 commented Jul 26, 2025

Add analytic tags to Journal Item search view

Forward port of #738.

Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review completed; functional review impossible due to an external dependency error when trying to install the module. Also tests error check fails.

@Daemo00 Daemo00 force-pushed the 18.0-imp-account_analytic_tag-search_views branch from 62a8762 to 1b67064 Compare August 8, 2025 10:41
@Daemo00
Copy link
Author

Daemo00 commented Aug 8, 2025

Technical review completed; functional review impossible due to an external dependency error when trying to install the module. Also tests error check fails.

Thanks for having a look!
I have rebased and now the module can be installed, please check.

Tests failure is probably not caused by this PR because they fail in 18.0 too, see #816.

@Daemo00 Daemo00 requested a review from luisDIXMIT August 8, 2025 10:52
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants