[18.0][MIG] sale_analytic_tag: Migration to 18.0 #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @carlos-lopez-tecnativa can you review CI error https://github.com/OCA/account-analytic/actions/runs/17397712587/job/49383312241?pr=827#step:8:417 related to |
victoralmau
force-pushed
the
18.0-mig-sale_analytic_tag
branch
from
d85d53f to
27e10d2
Compare
This should be resolved in #828 |
TT42276 [UPD] Update sale_analytic_tag.pot [BOT] post-merge updates
Translated using Weblate (Italian) Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-16.0/account-analytic-16.0-sale_analytic_tag Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-sale_analytic_tag/it/
Since odoo/odoo@d0342c8, the default existing company is not getting a CoA automatically, provoking than the current tests fail with the error: odoo.exceptions.UserError: No journal could be found in company My Company (San Francisco) for any of those types: sale Thus, we put tests post-install for being sure localization modules are installed, the same as AccountTestInvoicingCommon does, but we don't inherit from it, as it creates an overhead creating 2 new companies and loading their CoA and some more stuff, while we don't need all of that. Besides, if you don't have `l10n_generic_coa` installed, you can't use another CoA (like `l10n_es`) easily, so we put little code to select the first available CoA. [BOT] post-merge updates
[UPD] Update sale_analytic_tag.pot [BOT] post-merge updates
victoralmau
force-pushed
the
18.0-mig-sale_analytic_tag
branch
from
27e10d2 to
f05e172
Compare
|
/ocabot migration sale_analytic_tag |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4c671e1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 18.0
Please @carlos-lopez-tecnativa and @juancarlosonate-tecnativa can you review it?
@Tecnativa TT57844