[18.0][MIG] mis_builder_cash_flow: Migration to 18.0 #1320

geraldo29 · 2025-05-21T18:49:16Z

Migration from 17.0 to 18.0

Followed technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0.

Changes:
1)Removed migration folder
2)Changed 17 to 18 version in a few places
3)Changed tree to list in a few places.
4)Added test-requirements.txt

For mis_builder to compute correctly bale we need accounts with user type include_initial_balance. We use receivable type which is the more accurate for this purpose

Currently translated at 100.0% (52 of 52 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-mis_builder_cash_flow/pt/

Currently translated at 100.0% (53 of 53 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es_AR/

Currently translated at 37.7% (20 of 53 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/nl/

Currently translated at 81.1% (43 of 53 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es/

- On v13, invoices are journal entries, so we have to explicitly exclude cancelled invoices from the expression. We leave draft ones, as they are good for forecasting. - Default value for the company of the forecast line doesn't follow new specification, putting an incorrect value. - Extra improvement: avoid a non needed casting of the fixed column type.

"Target Moves" option in MIS report instance was previously ignored. Now it's taken into account, but still excluding cancelled entries.

Currently translated at 100.0% (55 of 55 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-mis_builder_cash_flow/es_AR/

Currently translated at 100.0% (55 of 55 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-mis_builder_cash_flow/it/

Currently translated at 100.0% (55 of 55 strings) Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-mis_builder_cash_flow/es/

Co-Authored-By: Stefan Ungureanu <[email protected]>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-16.0/account-financial-reporting-16.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-16-0/account-financial-reporting-16-0-mis_builder_cash_flow/

TT49378

Currently translated at 100.0% (54 of 54 strings) Translation: account-financial-reporting-16.0/account-financial-reporting-16.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-16-0/account-financial-reporting-16-0-mis_builder_cash_flow/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-mis_builder_cash_flow/

Currently translated at 100.0% (53 of 53 strings) Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-mis_builder_cash_flow Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-mis_builder_cash_flow/es_AR/

…ead of cr As stated in https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade.py#L297, the param should `env`, instead of the cursor

geraldo29 · 2025-05-21T22:46:25Z

Error: + pip install -r test-requirements.txt -c test-constraints.txt
Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi
Collecting odoo-addon-date_range==18.0.* (from -r test-requirements.txt (line 1))
Downloading https://wheelhouse.odoo-community.org/oca-simple/odoo-addon-date-range/odoo_addon_date_range-18.0.1.0.0.5-py3-none-any.whl (2.3 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 91.6 MB/s eta 0:00:00
ERROR: Could not find a version that satisfies the requirement odoo-addon-mis_builder==18.0.* (from versions: 15.0.1.0.1, 15.0.4.0.1, 15.0.4.0.2, 15.0.4.0.2.1, 15.0.4.0.3, 15.0.4.0.3.1, 15.0.4.0.3.2, 15.0.4.0.4, 15.0.4.0.5, 15.0.4.1.0, 15.0.4.1.0.1, 15.0.4.1.1, 15.0.4.1.2, 15.0.4.1.3, 15.0.4.1.3.1, 15.0.4.1.3.2, 15.0.4.1.3.3, 15.0.4.1.3.4, 15.0.4.1.3.5, 15.0.4.1.3.6, 15.0.4.1.3.7, 15.0.4.1.3.8, 15.0.4.1.4, 15.0.4.1.4.1, 15.0.4.1.4.2, 15.0.4.1.4.4, 15.0.4.1.5, 15.0.4.1.5.1, 15.0.4.1.5.2, 15.0.4.1.5.3, 15.0.4.1.5.4, 15.0.4.1.5.5, 15.0.4.1.5.6, 15.0.4.1.5.7, 15.0.4.1.5.8, 15.0.4.1.6, 15.0.4.1.6.1, 16.0.5.0.1, 16.0.5.0.1.1, 16.0.5.1.0.3, 16.0.5.1.0.4, 16.0.5.1.1, 16.0.5.1.1.1, 16.0.5.1.1.2, 16.0.5.1.1.4, 16.0.5.1.1.5, 16.0.5.1.2, 16.0.5.1.3, 16.0.5.1.3.2, 16.0.5.1.3.5, 16.0.5.1.3.7, 16.0.5.1.4, 16.0.5.1.4.3, 16.0.5.1.5, 16.0.5.1.5.1, 16.0.5.1.5.3, 16.0.5.1.6, 16.0.5.1.7, 16.0.5.1.7.2, 16.0.5.1.8, 16.0.5.1.9, 16.0.5.1.9.1, 16.0.5.1.9.2, 16.0.5.1.9.3, 16.0.5.1.9.4, 16.0.5.1.9.5, 16.0.5.1.9.6, 16.0.5.1.9.7, 16.0.5.1.9.8, 16.0.5.1.9.9, 16.0.5.1.10, 16.0.5.1.10.1, 16.0.5.1.11, 16.0.5.1.11.1, 16.0.5.1.11.2, 16.0.5.1.11.3, 16.0.5.1.11.6, 16.0.5.1.12, 16.0.5.1.12.1, 16.0.5.1.13, 16.0.5.2.0, 16.0.5.2.0.1, 16.0.5.2.1, 16.0.5.2.1.1, 16.0.5.2.2, 16.0.5.2.2.2, 16.0.5.2.2.3, 16.0.5.2.3, 16.0.5.2.3.1, 17.0.1.0.0.2, 17.0.1.0.0.3, 17.0.1.0.0.4, 17.0.1.0.0.6, 17.0.1.0.0.7, 17.0.1.0.1, 17.0.1.0.2, 17.0.1.0.3, 17.0.1.0.4, 17.0.1.0.4.1, 17.0.1.0.5, 17.0.1.1.0, 17.0.1.2.0, 17.0.1.2.0.1, 17.0.1.2.0.2, 17.0.1.2.1, 17.0.1.2.1.1)
ERROR: No matching distribution found for odoo-addon-mis_builder==18.0.*

No version 18 for https://wheelhouse.odoo-community.org/oca-simple/odoo-addon-mis-builder/

geraldo29 · 2025-06-14T20:54:13Z

Previous error of no version 18 was already fixed and that worked.

Changed company_id to company_ids manytomany

pedrobaeza · 2025-06-14T22:17:53Z

Please squash all your migration commits into one.

/ocabot migration mis_builder_cash_flow

geraldo29 · 2025-06-15T20:49:39Z

/ocabot migration mis_builder_cash_flow

OCA-git-bot · 2025-06-15T20:49:52Z

Sorry @geraldo29 you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

geraldo29 · 2025-06-15T22:26:43Z

Squashed commits. @pedrobaeza

geraldo29 · 2025-06-16T06:07:03Z

Tested in my Odoo 18 instance and working as expected. Let me know if any changes are needed. Thanks

pedrobaeza · 2025-06-16T06:41:04Z

OK, thanks, but the commit message is not correct:

It should be changed to:

[MIG] mis_builder_cash_flow: Migration to 18.0

Extra explanation about the changes done if you want.

geraldo29 · 2025-06-16T13:58:10Z

Changed commit message. Added the following:

pedrobaeza · 2025-06-20T06:28:34Z

Thanks for the changes. Testing the module in runboat, for forecast lines, the change of company_id to company_ids is not correct: the forecast line still should be to one company. And the field has been put as readonly. What you should do is to allow to search for accounts of that company (shared or not).

- Standard Odoo17->18 migration procedures - Replace company_id with company_ids (Many2one → Many2many) in forecast lines - Update constraint validation to check company overlap instead of exact match - Modify SQL query to handle Many2many relationship with proper JOIN - Update UI views to use many2many_tags widget for better UX - Fix test_company_constrain to properly test new validation logic - Update translations for new validation error message - Apply code formatting fixes for linting compliance - Fixes compatibility with Odoo 18's shared account model where account.account now uses company_ids instead of company_id

geraldo29 · 2025-06-25T05:09:31Z

Fixed forecast line to be one company and editable. Allowed for search for accounts of that company shared or not.

Squashed commits again.

pedrobaeza · 2025-07-05T08:02:13Z

mis_builder_cash_flow/report/mis_cash_flow.py

@@ -84,7 +84,7 @@ def init(self):
            WHERE aml.parent_state != 'cancel'
            UNION ALL
            SELECT
-                fl.id as id,
+                fl.id + 1000000 as id,


Why do you need this? If there's a conflict of ids, you are only delaying 100k records the conflict, not solving it.

pedrobaeza · 2025-08-28T09:23:26Z

@geraldo29 are you going to continue this migration? Please answer remaining questions.

jjscarafia and others added 30 commits May 21, 2025 10:04

[12.0][ADD] mis_builder_cash_flow module

a7131e6

[IMP] mis_builder_cash_flow: Add tests

221f808

[FIX] cash_flow: forecast accumulate next columns

c6c88d2

For mis_builder to compute correctly bale we need accounts with user type include_initial_balance. We use receivable type which is the more accurate for this purpose

Added translation using Weblate (Portuguese)

efca6ad

Added translation using Weblate (Catalan)

2dfed9d

Added translation using Weblate (Spanish)

5c7dbd0

[IMP] include partner_id in mis builder cash flow

31ecdf8

[IMP] partner_id in forecastline

e9ec5fc

[IMP] mis_builder_cash_flow: black, isort, prettier

26579e1

[MIG] mis_builder_cash_flow: Migration to 13.0

085cf28

Added translation using Weblate (Spanish (Argentina))

c229d6a

Added translation using Weblate (Dutch)

f9cadcc

[IMP] mis_builder_cash_flow: Consider states according selection

e2fc912

"Target Moves" option in MIS report instance was previously ignored. Now it's taken into account, but still excluding cancelled entries.

[IMP] mis_builder_cash_flow: black, isort, prettier

a79b3ba

[MIG] mis_builder_cash_flow: Migration to 14.0

19b4796

Added translation using Weblate (Italian)

af6c88b

[MIG] mis_builder_cash_flow: Migration to 15.0

2e0f717

[MIG] mis_builder_cash_flow: Migration to 16.0

58c4a72

Co-Authored-By: Stefan Ungureanu <[email protected]>

[UPD] Update mis_builder_cash_flow.pot

1ed35ec

oca-github-bot post-merge updates

b0f9baf

pedrobaeza and others added 9 commits May 21, 2025 10:04

[OU-ADD] mis_builder_cash_flow: Migration scripts

cf9efff

TT49378

[IMP] mis_builder_cash_flow: pre-commit auto fixes

82b45fe

[17.0][MIG] mis_builder_cash_flow

4a6a478

[UPD] Update mis_builder_cash_flow.pot

722f08e

[BOT] post-merge updates

4faebd9

[OU-FIX] mis_builder_cash_flow: use env in openupgrade load_data inst…

70fc36d

…ead of cr As stated in https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade.py#L297, the param should `env`, instead of the cursor

OCA-git-bot added this to the 18.0 milestone Jun 14, 2025

OCA-git-bot mentioned this pull request Jun 14, 2025

Migration to version 18.0 #1230

Open

4 tasks

pedrobaeza mentioned this pull request Jun 14, 2025

[18.0] [MIG] mis_builder_cash_flow #1312

Closed

geraldo29 force-pushed the 18.0-mig-mis_builder_cash_flow branch 2 times, most recently from 6900d46 to b85467e Compare June 15, 2025 21:32

geraldo29 force-pushed the 18.0-mig-mis_builder_cash_flow branch from b85467e to 8e6ce0c Compare June 16, 2025 13:55

geraldo29 force-pushed the 18.0-mig-mis_builder_cash_flow branch from 98e88a2 to 76f461a Compare June 25, 2025 05:06

pedrobaeza reviewed Jul 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] mis_builder_cash_flow: Migration to 18.0 #1320

[18.0][MIG] mis_builder_cash_flow: Migration to 18.0 #1320

Uh oh!

geraldo29 commented May 21, 2025

Uh oh!

geraldo29 commented May 21, 2025

Uh oh!

geraldo29 commented Jun 14, 2025

Uh oh!

pedrobaeza commented Jun 14, 2025

Uh oh!

geraldo29 commented Jun 15, 2025

Uh oh!

OCA-git-bot commented Jun 15, 2025

Uh oh!

geraldo29 commented Jun 15, 2025

Uh oh!

geraldo29 commented Jun 16, 2025 •

edited

Loading

Uh oh!

pedrobaeza commented Jun 16, 2025

Uh oh!

geraldo29 commented Jun 16, 2025

Uh oh!

pedrobaeza commented Jun 20, 2025

Uh oh!

geraldo29 commented Jun 25, 2025

Uh oh!

pedrobaeza Jul 5, 2025

Uh oh!

pedrobaeza commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

[18.0][MIG] mis_builder_cash_flow: Migration to 18.0 #1320

Are you sure you want to change the base?

[18.0][MIG] mis_builder_cash_flow: Migration to 18.0 #1320

Uh oh!

Conversation

geraldo29 commented May 21, 2025

Uh oh!

geraldo29 commented May 21, 2025

Uh oh!

geraldo29 commented Jun 14, 2025

Uh oh!

pedrobaeza commented Jun 14, 2025

Uh oh!

geraldo29 commented Jun 15, 2025

Uh oh!

OCA-git-bot commented Jun 15, 2025

Uh oh!

geraldo29 commented Jun 15, 2025

Uh oh!

geraldo29 commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Jun 16, 2025

Uh oh!

geraldo29 commented Jun 16, 2025

Uh oh!

pedrobaeza commented Jun 20, 2025

Uh oh!

geraldo29 commented Jun 25, 2025

Uh oh!

pedrobaeza Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Aug 28, 2025

Uh oh!

Uh oh!

geraldo29 commented Jun 16, 2025 •

edited

Loading