Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] account_invoice_production_lot #287

Conversation

aktiv-heli-kantawala
Copy link

No description provided.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 24, 2023
@matteoopenf
Copy link

matteoopenf commented Jan 22, 2024

@heliaktiv can you do a rebase?
I want test on rubboat to approve
Thank you

Copy link

@matteoopenf matteoopenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try in local env and it works fine

@matteoopenf
Copy link

@pedrobaeza is it possibile have a rebase?
thank you

@matteoopenf
Copy link

@etobella is it possibile have rebase? Because in locale env it works and we need the module
thank you so much for the help

@etobella
Copy link
Member

/ocabot rebase

eLBati and others added 19 commits January 25, 2024 10:00
* create decorator
* porting model to API 8.0
* tests
* report inovoice, adding SN on invoice report
* html formatting in formatted_note
* handled all type of invoicing policy
* description in README
* QWeb report
OCA Transbot updated translations from Transifex
On using the module, it results that an invoice with 2 lines, each
of them having a serial number, prints on the report both numbers
on each line. This technique has been the proper for avoiding the
problem.

OCA Transbot updated translations from Transifex
* Add unit tests to cover the following use case scenario.

  Steps to reproduce:

  * create a new product 'Product Test': stockable, Invoicing Policy as Delivered quantities, and tracking by lots
  * update its quantity to 3 with new lot 'Lot1'
  * update its quantity to 3 with new lot 'Lot2'
  * sale 4 of 'Product Test', confirm the SO
  * on the delivery, split the lots and set To Do quantities as 3 for Lot1 and leave 0 for Lot2
  * validate the delivery and create a backorder

  Current behavior:

  the field 'Production Lots' of the invoice generated is filled with both lots and, consequently,
  the invoice report will also contain info related to the lot not delivered yet.

  Expected behavior:

  the invoice report only contains info related to the lot involved in the delivery, which is Lot1.

* Improve README contents and regenerate it by using oca-gen-addon-readme
* Standard procedure
* Adapt code to new stock data model
* Adapt tests
* Fix README layout
* Remove coding lines in .py
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-account_invoice_production_lot/

[UPD] Update account_invoice_production_lot.pot
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-13.0/account-invoice-reporting-13.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-13-0/account-invoice-reporting-13-0-account_invoice_production_lot/

[UPD] Update account_invoice_production_lot.pot
Currently translated at 87.5% (7 of 8 strings)

Translation: account-invoice-reporting-13.0/account-invoice-reporting-13.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-13-0/account-invoice-reporting-13-0-account_invoice_production_lot/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoice-reporting-13.0/account-invoice-reporting-13.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-13-0/account-invoice-reporting-13-0-account_invoice_production_lot/es/
[UPD] Update account_invoice_production_lot.pot

[UPD] README.rst
If a product doesn't track lots, there are stock.move.line, but without
lot, and the report crashed before this commit due to getting a False as
lot name.

TT34868
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoice-reporting-14.0/account-invoice-reporting-14.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-14-0/account-invoice-reporting-14-0-account_invoice_production_lot/de/
victoralmau and others added 8 commits January 25, 2024 10:00
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-15.0/account-invoice-reporting-15.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-15-0/account-invoice-reporting-15-0-account_invoice_production_lot/
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoice-reporting-15.0/account-invoice-reporting-15.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-15-0/account-invoice-reporting-15-0-account_invoice_production_lot/ca/
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoice-reporting-15.0/account-invoice-reporting-15.0-account_invoice_production_lot
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-15-0/account-invoice-reporting-15-0-account_invoice_production_lot/es/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-account_invoice_production_lot branch from f0cd8c6 to b06de4b Compare January 25, 2024 10:00
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for tests and then I will merge 😉

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-287-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8340634 into OCA:16.0 Jan 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ce469a. Thanks a lot for contributing to OCA. ❤️

@matteoopenf
Copy link

Let's wait for tests and then I will merge 😉

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.