Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_invoice_report_grouped_by_picking: Migration to 17.0 #296

Conversation

lethuthao2403
Copy link

@lethuthao2403 lethuthao2403 commented Dec 7, 2023

ref: BSRD-699

chienandalu and others added 30 commits December 5, 2023 10:17
- When a return was in the original pickings it wasn't reflected in the
corresponding invoices correctly.
- Now we compute the total quantities of the moves recursively.
- When B2C prices was set, the orders where not properly grouped.
…iding edge cases

* The grouping is fully done on the prepare method
* It also computes the quantity applicable
* Adapt views to B2C/B2B cleanly
[FIX] account_invoice_report_grouped_by_picking: debug print remove

[FIX] account_invoice_report_grouped_by_picking: remove debug variable
…also with the related SO picking

Service lines that are not put on the pickings, remain on top of the invoice report due to this, but
it has more sense to have them grouped in the same picking block than the rest of their sales order
stockable lines.

Tests and README adapted.
…change position=replace in report_invoice.xml to prevent errors
notes

Avoid nasty exceptions. In the other hand it would be hard to fit the
concept of sections and notes to the picking groups in which this report
results.

TT29507
…lines for refund invoices without no returned quantities

TT27550
…ngs & sales

For manually created refund invoices that don't have pickings or orders, no lines were shown in the report
…ines

After the patch on stock_picking_invoice_link to link the refund moves to the return pickings created before the refund. This module shows on the picking duplicated lines.

With this patch the sign is correctly set and this duplication does not exist.

TT39916
ferran-S73 and others added 16 commits December 5, 2023 10:17
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_invoice_report_grouped_by_picking
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_invoice_report_grouped_by_picking/
…rovement

- Include context keys for avoiding mail operations overhead.
@lethuthao2403 lethuthao2403 mentioned this pull request Dec 7, 2023
8 tasks
@pedrobaeza
Copy link
Member

/ocabot migration account_invoice_report_grouped_by_picking

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 7, 2023
@gurneyalex
Copy link
Member

hello @lethuthao2403 I'm merging OCA/stock-logistics-workflow#1446 you should be able to remove the unreleased dependency.

@lethuthao2403 lethuthao2403 force-pushed the 17.0-mig-account_invoice_report_grouped_by_picking branch from 406f4a5 to 25f7da9 Compare December 8, 2023 10:18
@lethuthao2403
Copy link
Author

hello @lethuthao2403 I'm merging OCA/stock-logistics-workflow#1446 you should be able to remove the unreleased dependency.

@gurneyalex the PR has been updated! Thanks.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-296-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6d188ec into OCA:17.0 Dec 9, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40918ff. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.