[15.0][IMP] account_invoice_report_grouped_by_picking: Add possibility to set custom order at lines #299
Conversation
CarlosRoca13
changed the title
There was a problem hiding this comment.
This is not a good approach for adding hooks to be modified on custom modules, as it makes very difficult to follow the behavior on time.
Instead of passing an extra argument, move self.invoice_line_ids.sorted(lambda ln: (-ln.sequence, ln.date, ln.move_name, -ln.id), reverse=True) to a method that returns this sorted lines like _get_grouped_by_picking_sorted_lines), and you inherit such method in custom.
…et custom order at lines
CarlosRoca13
force-pushed
the
15.0-IMP-account_invoice_report_grouped_by_picking
branch
from
a98c752 to
f974d6f
Compare
|
Changed @pedrobaeza |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-299-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
This PR has the |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-299-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Changes have not yet been merged |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 48962fd. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-IMP-account_invoice_report_grouped_by_picking
branch
cc @Tecnativa TT46676
ping @sergio-teruel @carlosdauden