Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_comment_template: Migration to 17.0 #331

Merged

Conversation

RogerSans
Copy link

supersede: #317
This PR depends on OCA/reporting-engine#876

Standar migration
T-6435

@HaraldPanten
@ValentinVinagre

petrus-v and others added 23 commits July 24, 2024 09:35
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/hr/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/sv/
Currently translated at 50.0% (2 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/pt_BR/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoice-reporting-16.0/account-invoice-reporting-16.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-16-0/account-invoice-reporting-16-0-account_comment_template/pt_BR/
@RogerSans RogerSans mentioned this pull request Jul 24, 2024
8 tasks
@RogerSans RogerSans force-pushed the 17.0-mig-account_comment_template branch 2 times, most recently from a979165 to 5d936e2 Compare July 24, 2024 09:29
@HaraldPanten
Copy link

/ocabot migration account_comment_template

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 24, 2024
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@RogerSans
Copy link
Author

@manuelregidor Con you review this pls?

"name": "Account Comments",
"summary": "Comments templates on invoice documents",
"version": "17.0.1.0.0",
"category": "Sale",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think the category should be accounting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@RogerSans RogerSans force-pushed the 17.0-mig-account_comment_template branch from 19293f7 to 2378178 Compare July 25, 2024 08:45
Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@HaraldPanten
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-331-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 67b9735 into OCA:17.0 Jul 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a367411. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-account_comment_template branch July 25, 2024 10:10
BT-etejeda pushed a commit to BT-etejeda/account-invoice-reporting that referenced this pull request Feb 6, 2025
Syncing from upstream OCA/account-invoice-reporting (17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.