[15.0][FIX] account_invoice_report_grouped_by_picking: Method abs is called when remaining_qty is near of zero #337
Conversation
… when remaining_qty is near of zero TT51353
|
ping @sergio-teruel @chienandalu FWPort after merge |
carlosdauden
force-pushed
the
15.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
2 times, most recently
from
4cfd538 to
2d54c82
Compare
| @@ -101,45 +91,51 @@ def lines_grouped_by_picking(self): | |||
| } | |||
| ) | |||
| continue | |||
|
|
|||
There was a problem hiding this comment.
Please don't add empty lines inside a method, for both continuing with the existing style and as PEP8 recommendation.
There was a problem hiding this comment.
Changes done, but PEP8 allow blank lines in this cases:
Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations).
Use blank lines in functions, sparingly, to indicate logical sections.
There was a problem hiding this comment.
The main problem is that this method is too long and smaller methods should be created.
I discarded that change because all these methods are being declared in the account.move model.
The ultimate solution is to bring all this logic into an abstract_report, but I didn't want to do that in a stable release.
Let's keep that in mind for the migration to the new version.
…plify and remove OrderedDict From Python 3.7 dictionaries maintain the insertion order, so OrderedDict is unnecessary and adds overhead.
carlosdauden
force-pushed
the
15.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
from
2d54c82 to
04b4d84
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4d6a89c. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-FIX-account_invoice_report_grouped_by_picking-round_remaining_qty
branch
@Tecnativa TT51353