[18.0][MIG] account_receipt_journal

[rjaraspearhead]

No description provided.

[rjaraspearhead]

Hi @Shide, @SirTakobi
could you help with the review of this module?

@eLBati , if applicable, could you check the functionality in the localization?

[Shide]

When you create a receipt, default journal is not set to a receipt journal (happens on sale receipt and purchase receipt).
A receipt journal must be set if is any exclusive to receipts.

[rjaraspearhead]

When you create a receipt, default journal is not set to a receipt journal (happens on sale receipt and purchase receipt). A receipt journal must be set if is any exclusive to receipts.

The receipt journals are being created by default in the data files included in the module.
Let us know if you think additional configuration is needed to properly set the default journal on receipt creation.

[rjaraspearhead]

Test fix: #2056

[Shide]

When you create a receipt, default journal is not set to a receipt journal (happens on sale receipt and purchase receipt). A receipt journal must be set if is any exclusive to receipts.

The receipt journals are being created by default in the data files included in the module. Let us know if you think additional configuration is needed to properly set the default journal on receipt creation.

A receipt Journal must be set when creating a receipt like in v16.
It's not happening in v18 (don't know the reason, but it's not happening)

[rjaraspearhead]

When you create a receipt, default journal is not set to a receipt journal (happens on sale receipt and purchase receipt). A receipt journal must be set if is any exclusive to receipts.

The receipt journals are being created by default in the data files included in the module. Let us know if you think additional configuration is needed to properly set the default journal on receipt creation.

A receipt Journal must be set when creating a receipt like in v16. It's not happening in v18 (don't know the reason, but it's not happening)

I fixed the issue so that a receipt journal is selected by default when creating a receipt.

[EmilioPascual]

MT-11039 @moduon

[Gelojr]

Review result: NOT OK. @rjaraspearhead a revision is required because creating receipts from journal views is inconsistent: in Sales, using “New” inside the journal creates an out_invoice instead of an out_receipt, and in Purchases, creating from Kanban or inside the journal produces a vendor bill (in_invoice) and/or error.

• Test 1: OK — Sale/Purchase Receipt Journals exist with receipts=True and higher sequence than other journals of the same type.
• Test 2: NOK — From Kanban “New” in Sale Receipts Journal creates an out_receipt (OK), but using “New” inside the journal creates a customer invoice (out_invoice) instead of a receipt.

• Test 3: NOK — Creating a purchase receipt from Kanban or inside the journal/list yields a vendor bill (in_invoice) and/or error; expected in_receipt.

• Test 4: OK — In a customer invoice (out_invoice), receipt-only journals are not listed in the Journal selector.
• Test 5: OK — In a customer receipt (out_receipt), only receipt-only journals are listed in the Journal selector.
• Test 6: OK — Journal selector respects move type in general: excludes receipt-only journals for invoices and restricts to them for receipts.

[rjaraspearhead]

Review result: NOT OK. @rjaraspearhead a revision is required because creating receipts from journal views is inconsistent: in Sales, using “New” inside the journal creates an out_invoice instead of an out_receipt, and in Purchases, creating from Kanban or inside the journal produces a vendor bill (in_invoice) and/or error.

• Test 1: OK — Sale/Purchase Receipt Journals exist with receipts=True and higher sequence than other journals of the same type.
• Test 2: NOK — From Kanban “New” in Sale Receipts Journal creates an out_receipt (OK), but using “New” inside the journal creates a customer invoice (out_invoice) instead of a receipt.

• Test 3: NOK — Creating a purchase receipt from Kanban or inside the journal/list yields a vendor bill (in_invoice) and/or error; expected in_receipt.

• Test 4: OK — In a customer invoice (out_invoice), receipt-only journals are not listed in the Journal selector.
• Test 5: OK — In a customer receipt (out_receipt), only receipt-only journals are listed in the Journal selector.
• Test 6: OK — Journal selector respects move type in general: excludes receipt-only journals for invoices and restricts to them for receipts.

@Gelojr
I added the open_action method when clicking on the Journal name.

Could you please review it?

[Gelojr]

Review result: NOT OK. Limiting scope to Tests 2 and 3. Test 3 fails

• Test 2: OK — Creating a sales receipt works both from the Sale Receipts Journal Kanban “New” and from the Journal List view; the flow that was previously NOK (creating from inside the journal/list) now behaves as expected.
• Test 3: NOT OK — In Purchases, the “Upload” and “Drag & drop” flows fails

[rjaraspearhead]

Review result: NOT OK. Limiting scope to Tests 2 and 3. Test 3 fails

• Test 2: OK — Creating a sales receipt works both from the Sale Receipts Journal Kanban “New” and from the Journal List view; the flow that was previously NOK (creating from inside the journal/list) now behaves as expected.
• Test 3: NOT OK — In Purchases, the “Upload” and “Drag & drop” flows fails

Could you review the "Create a bill manually" button?
Regarding Upload and Drag & Drop, I have prepared a roadmap.

Perhaps you have some suggestions, or could you help me with this part?

[Gelojr]

Review result: NOT OK. Limiting scope to Tests 2 and 3. Test 3 fails

• Test 2: OK — Creating a sales receipt works both from the Sale Receipts Journal Kanban “New” and from the Journal List view; the flow that was previously NOK (creating from inside the journal/list) now behaves as expected.
• Test 3: NOT OK — In Purchases, the “Upload” and “Drag & drop” flows fails

Could you review the "Create a bill manually" button? Regarding Upload and Drag & Drop, I have prepared a roadmap.

Perhaps you have some suggestions, or could you help me with this part?

The button "Create a bill manually" works properly. The other two options are the ones that don't work.

Perhaps you have some suggestions, or could you help me with this part?

Sorry, I'm not technician. I'm functional consultor. I don't know how to develope

[rjaraspearhead]

Review result: NOT OK. Limiting scope to Tests 2 and 3. Test 3 fails

• Test 2: OK — Creating a sales receipt works both from the Sale Receipts Journal Kanban “New” and from the Journal List view; the flow that was previously NOK (creating from inside the journal/list) now behaves as expected.
• Test 3: NOT OK — In Purchases, the “Upload” and “Drag & drop” flows fails

Could you review the "Create a bill manually" button? Regarding Upload and Drag & Drop, I have prepared a roadmap.
Perhaps you have some suggestions, or could you help me with this part?

The button "Create a bill manually" works properly. The other two options are the ones that don't work.

Perhaps you have some suggestions, or could you help me with this part?

Sorry, I'm not technician. I'm functional consultor. I don't know how to develope

[rjaraspearhead]

#2054 (comment)
@Gelojr
I’m leaving test 3 in the roadmap for a future implementation.

[Gelojr]

Okay. Then I'll approve it.

[Gelojr]

Congratulations on the work @rjaraspearhead. PR approved; current scope is OK, with Test 3 not correct and added to the roadmap for a future implementation.
The following tests were executed:
Test 1: OK — Receipt journals exist (receipts=True) with higher sequence than other journals of the same type.
Test 2: OK — Sales receipt creation works from both the Sale Receipts Journal Kanban “New” and the Journal List view; the flow that was previously NOK from inside the journal/list now behaves as expected.
Test 3: NOT OK — In Purchases, the “Upload” and “Drag & drop” flows do not create an in_receipt (they create a vendor bill or fail); working paths are Kanban “New” and List “New”; added to the roadmap.
Test 4: OK — In a customer invoice (out_invoice), receipt-only journals are not listed in the Journal selector.
Test 5: OK — In a customer receipt (out_receipt), only receipt-only journals are listed in the Journal selector.
Test 6: OK — Journal selector respects the move type overall: excludes receipt-only journals for invoices and restricts to them for receipts.

[Shide]

Code review

[rafaelbn]

/ocabot migration account_receipt_journal

[rafaelbn]

/ocabot rebase

[OCA-git-bot]

Congratulations, PR rebased to 18.0.

[rafaelbn]

Thank you for this migration @rjaraspearhead 😄 ❤️

@loida-vm and @u0f from @moduon

Next week we should finish this PR 💪🏼 💘