[16.0][IMP] account_reconcile_oca: Improve usability when using Reconcile Mode = 'Keep suspense accounts' #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
| <field | ||
| name="reconciled_line_ids" | ||
| nolabel="1" | ||
| attrs="{'invisible': [('reconcile_mode', '!=', 'keep')]}" |
There was a problem hiding this comment.
Suggested change
| attrs="{'invisible': [('reconcile_mode', '!=', 'keep')]}" | |
| attrs="{'invisible': ['|', ('reconcile_mode', '!=', 'keep'), ('reconciled_line_ids', '=', [])]}" |
There was a problem hiding this comment.
@JordiMForgeFlow fixed!
There was a problem hiding this comment.
when I unreconcile a transaction that I previously reconciled, it still shows:
Maybe we should try ('reconciled_line_ids', '=', False) instead of ('reconciled_line_ids', '=', [])
There was a problem hiding this comment.
@JordiMForgeFlow Made a mistake. Now should be fixed.
JordiBForgeFlow
force-pushed
the
16.0-imp-account_reconcile_oca-keep
branch
from
9b30e9e to
5e66a3c
Compare
…se accounts', do show the reconciled move lines in the reconciliation screen, and show a button 'View moves' instead of 'View move'. This change makes it much easier for the user to review what accounts did the user choose to reconcile the statement line with.
JordiBForgeFlow
force-pushed
the
16.0-imp-account_reconcile_oca-keep
branch
from
5e66a3c to
1c60ba2
Compare
JordiMForgeFlow
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Reconcile Mode = 'Keep suspense accounts' do show the reconciled move lines in the reconciliation screen, and show a button 'View moves' instead of 'View move'.
This change makes it much easier for the user to review what accounts did the user choose to reconcile the statement line with.
@etobella @JordiMForgeFlow