-
-
Notifications
You must be signed in to change notification settings - Fork 445
[16.0][IMP] account_reconcile_oca: Show Open Balance #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @etobella, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
a767b7e
to
8732744
Compare
ping @etobella |
Thanks for the review, @pedrobaeza. This is the expected behavior: “Open Balance” is shown only when there isn’t a counterpart entry for the residual amount. In practice, it’s mainly useful in the Accounting Reconciliation panel (Invoicing → Accounting → Reconcile). In the Bank Reconciliation panel, the system automatically creates a counterpart (the bank suspense line) for each statement line, which effectively replaces the Open Balance. That’s why you see the suspense account line instead. |
OK, understood. What a would want is to have "replaced" that suspense account line with the "Open balance" line (being still clickable for adding manual operation), as it's a bit confusing to have it as a regular line. Or at least to grey out. Is that possible? |
Hello @antoniospneto, There is my proposal to grey the suspense account line (and there is a screenshot to see how it looks like) : I didn't want to push directly on your PR, that's why I've created a PR on your PR :) |
Thanks for the PR ! |
21de4fe
to
f910d62
Compare
@mondot Thanks for the help! @pedrobaeza Thanks for the review. Changing the “suspense account” mechanism is a broader, more complex change and it’s not something I plan to tackle in this PR. Here I’m only improving the reconciliation flow on the account.account.reconcile side, where the “suspense account” mechanism is not applicable. |
Here’s how both views look after @mondot’s contribution.
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Can you confirm, @etobella?
Adds a dedicated “Open Balance” row to the reconciliation widget so users can instantly see the remaining (unreconciled) amount while matching journal items.
Resolve #805
Screenshot:
