[18.0][MIG] agreement_account: Migration to 18.0

[BhaveshHeliconia]

No description provided.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[rafaelbn]

/ocabot migration agreement_account

[rafaelbn]

@moduon MT-9987

/ocabot rebase

[OCA-git-bot]

@rafaelbn The rebase process failed, because command git push --force HeliconiaIO tmp-pr-58:18.0-mig-agreement_account failed with output:

remote: Permission to HeliconiaIO/agreement.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/HeliconiaIO/agreement/': The requested URL returned error: 403

[rafaelbn]

Please @BhaveshHeliconia , could you rebase to get test 🍏 😄 Thank you!

[imlopes]

LGTM

[BhaveshHeliconia]

@rafaelbn : The tests are green now. Thank you!

[Gelojr]

Congratulations on the work—great job!
I executed the following tests and obtained these results:

• Test 1: Customer invoice → Agreement field shown under Other Info, filtered by commercial partner (sale) and editable only in draft; after validation it becomes read-only; Result: OK.
• Test 2: Vendor bill → Agreement field filtered by commercial partner (purchase); Result: OK; Note: after validation the Agreement field remains editable (not read-only), unlike customer invoices.
• Test 3: Agreement (sale) smart button “Invoices” → Counter includes invoices and credit notes and opens the filtered list; Result: OK; Note: when generating a customer credit note from an invoice, the Agreement is not copied automatically and must be assigned manually.
• Test 4: Agreement (purchase) smart button “Vendor Bills” → Counter includes vendor bills and refunds and opens the filtered list; Result: OK; Note: when generating a vendor refund from a bill, the Agreement is not copied automatically and must be assigned manually.
• Test 5: Invoice search/group by Agreement → Filter and group by Agreement work as expected; Result: OK;
• Test 6: Deletion integrity → Attempting to delete an Agreement with linked invoices is blocked by ondelete=restrict; Result: OK.
• Test 7: Commercial partner hierarchy → An Agreement set on the parent partner can be selected on an invoice for a child contact thanks to child_of; Result: OK. Note: unlike agreement_sale, agreement_account only allows selecting Agreements of the invoice’s commercial partner (and its child contacts); Agreements from other partners do not appear in the dropdown.

Final note: There are inconsistencies with agreement_sale regarding domain filtering and the ability to select Agreements not linked to the invoice’s commercial partner; agreement_account restricts selection to the commercial partner and its child contacts, while agreement_sale allows selecting Agreements for different partners.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Shide]

Code review

[rafaelbn]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-58-by-rafaelbn-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1d6e4bc. Thanks a lot for contributing to OCA. ❤️