[17.0][FIX] product_brand: Rule product.brand.public has no group #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review please ? regards, |
randall-vx
changed the title
|
Hi @randall-vx, Why do you think leaving an empty group is deprecated? |
@luisg123v Odoo shows a log error in a docker test instance according to this changes: Log errorregards, |
* Rule product.brand.public has no group, this is a deprecated feature. odoo/odoo#125216 * Every access-granting rule should specify a group. odoo/odoo@ce1a4a2
randall-vx
force-pushed
the
17.0-dev-product-brand-group-randallvx
branch
from
d6a5d07 to
7842e00
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7cc8ade. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule product.brand.public has no group, this is a deprecated feature.
[IMP] *: remove global rules odoo/odoo#125216
Every access-granting rule should specify a group. odoo/odoo@ce1a4a2