Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] resource_booking: get_intervals #136

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] resource_booking: get_intervals #136

wants to merge 2 commits into from

Conversation

norlinhenrik
Copy link

@norlinhenrik norlinhenrik commented Jul 31, 2024 •
edited
Loading

Current workflow: Create a booking with a booking type, then check availablility.

Needed workflow: Check availability for a booking type without creating a booking.

_get_intervals() has a new input argument:

  • start_dt
  • end_dt
  • combination=None
  • type=None

2nd commit: maintainers. Shall I squash the commits?

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @ows-cloud,
some modules you are maintaining are being modified, check this out!

@norlinhenrik
[IMP] resource_booking: get_intervals
8724893 
Now we can get intervals of an empty booking,
by specifying the needed values, including the booking type.
@norlinhenrik
[FIX] resource_booking: ows-cloud -> norlinhenrik
4a1a3e7
@norlinhenrik norlinhenrik force-pushed the 16.0-imp-resource_booking-get-intervals branch 2 times, most recently from 051bdd0 to 4a1a3e7 Compare August 6, 2024 09:05
@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 5, 2024
pedrobaeza
pedrobaeza requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use type, as it's a semi-reserved word. Use for example rb_type. Anyway, I don't get the sense of the code, as you are still assigning a booking type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@norlinhenrik @OCA-git-bot @pedrobaeza