Skip to content

[18.0] [MIG] commission_formula: Migration to 18.0 + rename commission_formula_oca #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [MIG] commission_formula: Migration to 18.0 + rename commission_formula_oca #637

wants to merge 16 commits into from

Conversation

@Borruso
Copy link
Contributor

@Borruso Borruso commented Aug 29, 2025

No description provided.

andrel-exo and others added 15 commits August 29, 2025 16:07
@andrel-exo @Borruso
[16.0][MIG] commission_formula
ae58799
@andrel-exo @Borruso
[16.0][IMP] added widget ace to formula field
2740638
@Ivorra78 @Borruso
Translated using Weblate (Spanish)
d7ee9ee 
Currently translated at 100.0% (14 of 14 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/es/
@adrianojprado @Borruso
Translated using Weblate (Portuguese (Brazil))
6a85ef8 
Currently translated at 100.0% (14 of 14 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/pt_BR/
@Ivorra78 @Borruso
Translated using Weblate (Spanish)
66fc666 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/es/
@extrememicro @Borruso
Translated using Weblate (Catalan)
e609d15 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/ca/
@Tisho99 @Borruso
[IMP] commission_formula: pre-commit auto fixes
057f271
@Tisho99 @Borruso
[MIG] commission_formula: Migration to 17.0
0d233b4
@luis-ron @Borruso
Translated using Weblate (Spanish)
1c8b716 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/es/
@mymage @Borruso
Translated using Weblate (Italian)
7a4fe4c 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
@SottomaiorMacedoTec @Borruso
Translated using Weblate (Portuguese (Brazil))
842d50d 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/pt_BR/
@metingulsoy @Borruso
Translated using Weblate (Turkish)
f1c9e3d 
Currently translated at 93.3% (14 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/tr/
@mymage @Borruso
Translated using Weblate (Italian)
0c1209a 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
@mymage @Borruso
Translated using Weblate (Italian)
b73320b 
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
@Borruso
[IMP] commission_formula: pre-commit auto fixes
ab63c37
@pedrobaeza
Copy link
Member

pedrobaeza commented Sep 1, 2025

/ocabot migration commission_formula

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Sep 1, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 1, 2025
Open
7 tasks
david-banon-tecnativa
david-banon-tecnativa suggested changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR. You need to specify openupgradelib as a dependency in order to get it installed on CI.

TT57626

@Borruso Borruso force-pushed the 18.0-mig-commission_formula_oca branch 2 times, most recently from 6fe381d to c78169a Compare September 5, 2025 10:20
david-banon-tecnativa
david-banon-tecnativa approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK, some test should be added, but works as expected

pedrobaeza
pedrobaeza requested changes Sep 10, 2025
View reviewed changes
commission_formula_oca/__init__.py Outdated
from openupgradelib import openupgrade


def _commission_formula_oca_pre_init_hook(env):
Copy link
Member

@pedrobaeza pedrobaeza Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here, but on OpenUpgrade.

Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borruso OCA/OpenUpgrade#5372 is an example of what needs to be done on OpenUpgrade

@Borruso Borruso force-pushed the 18.0-mig-commission_formula_oca branch from c78169a to fef0266 Compare September 15, 2025 15:45
@Borruso Borruso mentioned this pull request Sep 15, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

+1 more reviewer

@david-banon-tecnativa david-banon-tecnativa david-banon-tecnativa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.