Skip to content

Commit

Permalink
[MIG] hr_recruitment_phone: Migration to 16.0
Browse files Browse the repository at this point in the history
  • Loading branch information
PauBForgeFlow committed Jan 3, 2024
1 parent b092c69 commit 113a655
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 20 deletions.
12 changes: 6 additions & 6 deletions hr_recruitment_phone/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ HR Recruitment Phone
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:d2edef1508138114b005bad7a0ffa11e3a55a0d2a780aaebc1f89d9de5b4f9b6
!! source digest: sha256:1a12acc7def0f216ab639594ac382e42d9e58af927170d661f49178228f0f4d8
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
Expand All @@ -17,13 +17,13 @@ HR Recruitment Phone
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fconnector--telephony-lightgray.png?logo=github
:target: https://github.com/OCA/connector-telephony/tree/14.0/hr_recruitment_phone
:target: https://github.com/OCA/connector-telephony/tree/16.0/hr_recruitment_phone
:alt: OCA/connector-telephony
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-hr_recruitment_phone
:target: https://translation.odoo-community.org/projects/connector-telephony-16-0/connector-telephony-16-0-hr_recruitment_phone
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/connector-telephony&target_branch=14.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/connector-telephony&target_branch=16.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|
Expand All @@ -42,7 +42,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/connector-telephony/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/connector-telephony/issues/new?body=module:%20hr_recruitment_phone%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/connector-telephony/issues/new?body=module:%20hr_recruitment_phone%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Expand Down Expand Up @@ -80,6 +80,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:

|maintainer-alexis-via|

This module is part of the `OCA/connector-telephony <https://github.com/OCA/connector-telephony/tree/14.0/hr_recruitment_phone>`_ project on GitHub.
This module is part of the `OCA/connector-telephony <https://github.com/OCA/connector-telephony/tree/16.0/hr_recruitment_phone>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
2 changes: 1 addition & 1 deletion hr_recruitment_phone/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{
"name": "HR Recruitment Phone",
"version": "14.0.1.0.0",
"version": "16.0.1.0.0",
"category": "Phone",
"license": "AGPL-3",
"summary": "Validate phone numbers in HR Recruitment",
Expand Down
2 changes: 1 addition & 1 deletion hr_recruitment_phone/models/hr_applicant.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

class HrApplicant(models.Model):
_name = "hr.applicant"
_inherit = ["hr.applicant", "phone.validation.mixin"]
_inherit = ["hr.applicant"]
_phone_name_sequence = 50
_phone_name_fields = ["partner_phone", "partner_mobile"]

Expand Down
8 changes: 4 additions & 4 deletions hr_recruitment_phone/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,9 @@ <h1 class="title">HR Recruitment Phone</h1>
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:d2edef1508138114b005bad7a0ffa11e3a55a0d2a780aaebc1f89d9de5b4f9b6
!! source digest: sha256:1a12acc7def0f216ab639594ac382e42d9e58af927170d661f49178228f0f4d8
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/connector-telephony/tree/14.0/hr_recruitment_phone"><img alt="OCA/connector-telephony" src="https://img.shields.io/badge/github-OCA%2Fconnector--telephony-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-hr_recruitment_phone"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/connector-telephony&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/connector-telephony/tree/16.0/hr_recruitment_phone"><img alt="OCA/connector-telephony" src="https://img.shields.io/badge/github-OCA%2Fconnector--telephony-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/connector-telephony-16-0/connector-telephony-16-0-hr_recruitment_phone"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/connector-telephony&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>This module validates phone numbers in the Applicant form of the <em>Recruitment</em> module, just like the
<em>phone_validation</em> module valide phone numbers in the Partner form. It also adds phone number lookup on applicants on incoming calls.</p>
<p><strong>Table of contents</strong></p>
Expand All @@ -389,7 +389,7 @@ <h1><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/connector-telephony/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/connector-telephony/issues/new?body=module:%20hr_recruitment_phone%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/OCA/connector-telephony/issues/new?body=module:%20hr_recruitment_phone%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
Expand All @@ -415,7 +415,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h2>
promote its widespread use.</p>
<p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
<p><a class="reference external image-reference" href="https://github.com/alexis-via"><img alt="alexis-via" src="https://github.com/alexis-via.png?size=40px" /></a></p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/connector-telephony/tree/14.0/hr_recruitment_phone">OCA/connector-telephony</a> project on GitHub.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/connector-telephony/tree/16.0/hr_recruitment_phone">OCA/connector-telephony</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
</div>
</div>
Expand Down
18 changes: 10 additions & 8 deletions hr_recruitment_phone/tests/test_phone.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,21 @@ def setUp(self):
self.fr_country_id = self.env.ref("base.fr").id
self.phco = self.env["phone.common"]
self.env.company.write({"country_id": self.fr_country_id})
self.test_record = self.env["hr.applicant"].create(
self.partner = self.env["res.partner"].create(
{
"name": "Expert Odoo",
"partner_name": "Alexis de Lattre",
"partner_phone": "+33 4 78 52 52 52",
"name": "Partner 0",
"country_id": self.fr_country_id,
"phone": "+33 4 78 32 32 32",
}
)

def test_lookup(self):
res = self.phco.get_record_from_phone_number("0478525252")
res = self.phco.get_record_from_phone_number("0478323232")
self.assertIsInstance(res, tuple)
self.assertEqual(res[0], "hr.applicant")
self.assertEqual(res[1], self.test_record.id)
self.assertEqual(res[0], "res.partner")
self.assertEqual(res[1], self.partner.id)
self.assertEqual(
res[2], self.test_record.with_context(callerid=True).name_get()[0][1]
res[2], self.partner.with_context(callerid=True).name_get()[0][1]
)
res = self.phco.get_record_from_phone_number("0499889988")
self.assertFalse(res)

0 comments on commit 113a655

Please sign in to comment.