[17.0] [MIG] asterisk_click2dial: Migration to 17.0 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisDIXMIT
force-pushed
the
17.0-mig-asterisk_click2dial
branch
from
373df46
to
a077af2
Compare
etobella
force-pushed
the
17.0-mig-asterisk_click2dial
branch
from
018fc5b
to
a8eb281
Compare
luisDIXMIT
force-pushed
the
17.0-mig-asterisk_click2dial
branch
5 times, most recently
from
7d6495a
to
1835811
Compare
etobella
approved these changes
Apr 11, 2024
|
/ocabot migration asterisk_click2dial |
|
@luisDIXMIT can you apply changes of v16 please |
added 18 commits
May 6, 2024 11:37
Long life to the asterisk_click2dial module for OpenERP !
- option to allow the use of phone numbers in National format, as discussed with Albert. This option is on the definition of the server. -> required a large change of the reformat number process - added exact link to documentation in module description - some clean-up
but he also made the change in the name of the SIP header ! This commit reverts this mistake.
In fact, it corresponds to the 'Timeout' instruction for the Asterisk Manager
Add French translation for these messages.
- Convert the comments for the functions to the standard style
Added "active" field on asterisk.server object. In order to access all the Asterisk servers, included the desactivated ones, I added a view dedicated to the object asterisk.server, which is accessible under Administration > Configuration.
Thanks to Bernat Brunet from NaN for pointing this out.
Make phone and mobile fields searchable Took into account some pylint coding convention suggestions
- we now handle the fact that phone numbers may contain spaces or special chars such in OpenERP, which is often the case in real life - check input number
Added a comment about the user rights.
… feature Update module description.
Update in comments
…ber in the callerID instruction to Asterisk. Patch courtesy of Marcel van der Boom. Thanks for your feedback !
Accoring to my tests and the info I got, SIP phones support UTF-8 fine - Create a command line option to convert the name from UTF-8 to ASCII (-a) - add default parameter to the help message
Currently translated at 100.0% (91 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/pt_BR/
Currently translated at 96.7% (88 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/es_AR/
Currently translated at 7.6% (7 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/it/
Currently translated at 8.7% (8 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/
Currently translated at 100.0% (91 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/es/
luisDIXMIT
force-pushed
the
17.0-mig-asterisk_click2dial
branch
from
1835811
to
cdf4b73
Compare
|
@cvinh comments looked after. Migration done from v16 |
cvinh
reviewed
May 7, 2024
| "Connection Test Successfull! Odoo can successfully login to" | ||
| "Asterisk." | ||
| ), | ||
| "message": _("Your request has been successfully sent"), |
There was a problem hiding this comment.
Same as for v16, please keep the original message
There was a problem hiding this comment.
You're right. I have updated it.
luisDIXMIT
force-pushed
the
17.0-mig-asterisk_click2dial
branch
from
0b785e7
to
c45252d
Compare
cvinh
approved these changes
May 7, 2024
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at b8c0c55. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed js after considering it unnecessary
@etobella @alexis-via